Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-11-03 Thread Michael S. Tsirkin
On Wed, Nov 03, 2021 at 08:51:42AM +0100, Jean-Louis Dupond wrote: > On 1/11/2021 23:26, Michael S. Tsirkin wrote: > > On Tue, Oct 12, 2021 at 10:24:28AM +0200, Jean-Louis Dupond wrote: > > > hw_compat modes only take into account their base name. > > > But if a device is created with (non)-transit

Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-11-03 Thread Jean-Louis Dupond
On 1/11/2021 23:26, Michael S. Tsirkin wrote: On Tue, Oct 12, 2021 at 10:24:28AM +0200, Jean-Louis Dupond wrote: hw_compat modes only take into account their base name. But if a device is created with (non)-transitional, then the compat values are not used, causing migrating issues. This commit

Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-11-01 Thread Michael S. Tsirkin
On Tue, Oct 12, 2021 at 10:24:28AM +0200, Jean-Louis Dupond wrote: > hw_compat modes only take into account their base name. > But if a device is created with (non)-transitional, then the compat > values are not used, causing migrating issues. > > This commit adds their (non)-transitional entries

Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-10-20 Thread Eduardo Habkost
On Wed, Oct 20, 2021 at 10:58:12AM -0400, Michael S. Tsirkin wrote: > On Wed, Oct 20, 2021 at 10:09:17AM -0400, Eduardo Habkost wrote: > > On Wed, Oct 20, 2021 at 01:02:24PM +0800, Jason Wang wrote: > > > On Wed, Oct 20, 2021 at 9:31 AM Jason Wang wrote: > > > > > > > > On Wed, Oct 20, 2021 at 12:

Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-10-20 Thread Michael S. Tsirkin
On Wed, Oct 20, 2021 at 11:01:43AM -0400, Eduardo Habkost wrote: > On Wed, Oct 20, 2021 at 10:55:59AM -0400, Michael S. Tsirkin wrote: > > On Wed, Oct 20, 2021 at 09:57:37AM -0400, Eduardo Habkost wrote: > > > On Wed, Oct 20, 2021 at 03:41:38AM -0400, Michael S. Tsirkin wrote: > > > > On Tue, Oct 1

Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-10-20 Thread Eduardo Habkost
On Wed, Oct 20, 2021 at 10:55:59AM -0400, Michael S. Tsirkin wrote: > On Wed, Oct 20, 2021 at 09:57:37AM -0400, Eduardo Habkost wrote: > > On Wed, Oct 20, 2021 at 03:41:38AM -0400, Michael S. Tsirkin wrote: > > > On Tue, Oct 19, 2021 at 12:56:11PM -0400, Eduardo Habkost wrote: > > > > On Tue, Oct 1

Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-10-20 Thread Michael S. Tsirkin
On Wed, Oct 20, 2021 at 10:09:17AM -0400, Eduardo Habkost wrote: > On Wed, Oct 20, 2021 at 01:02:24PM +0800, Jason Wang wrote: > > On Wed, Oct 20, 2021 at 9:31 AM Jason Wang wrote: > > > > > > On Wed, Oct 20, 2021 at 12:56 AM Eduardo Habkost > > > wrote: > > > > > > > > On Tue, Oct 19, 2021 at 1

Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-10-20 Thread Michael S. Tsirkin
On Wed, Oct 20, 2021 at 09:57:37AM -0400, Eduardo Habkost wrote: > On Wed, Oct 20, 2021 at 03:41:38AM -0400, Michael S. Tsirkin wrote: > > On Tue, Oct 19, 2021 at 12:56:11PM -0400, Eduardo Habkost wrote: > > > On Tue, Oct 19, 2021 at 12:13:17PM -0400, Michael S. Tsirkin wrote: > > > > On Tue, Oct 1

Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-10-20 Thread Eduardo Habkost
On Wed, Oct 20, 2021 at 01:02:24PM +0800, Jason Wang wrote: > On Wed, Oct 20, 2021 at 9:31 AM Jason Wang wrote: > > > > On Wed, Oct 20, 2021 at 12:56 AM Eduardo Habkost > > wrote: > > > > > > On Tue, Oct 19, 2021 at 12:13:17PM -0400, Michael S. Tsirkin wrote: > > > > On Tue, Oct 19, 2021 at 11:2

Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-10-20 Thread Eduardo Habkost
On Wed, Oct 20, 2021 at 03:41:38AM -0400, Michael S. Tsirkin wrote: > On Tue, Oct 19, 2021 at 12:56:11PM -0400, Eduardo Habkost wrote: > > On Tue, Oct 19, 2021 at 12:13:17PM -0400, Michael S. Tsirkin wrote: > > > On Tue, Oct 19, 2021 at 11:29:13AM -0400, Eduardo Habkost wrote: > > > > On Tue, Oct 1

Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-10-20 Thread Michael S. Tsirkin
On Tue, Oct 19, 2021 at 12:56:11PM -0400, Eduardo Habkost wrote: > On Tue, Oct 19, 2021 at 12:13:17PM -0400, Michael S. Tsirkin wrote: > > On Tue, Oct 19, 2021 at 11:29:13AM -0400, Eduardo Habkost wrote: > > > On Tue, Oct 19, 2021 at 06:59:09AM -0400, Michael S. Tsirkin wrote: > > > > On Tue, Oct 1

Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-10-20 Thread Jean-Louis Dupond
On 19/10/2021 18:56, Eduardo Habkost wrote: On Tue, Oct 19, 2021 at 12:13:17PM -0400, Michael S. Tsirkin wrote: On Tue, Oct 19, 2021 at 11:29:13AM -0400, Eduardo Habkost wrote: On Tue, Oct 19, 2021 at 06:59:09AM -0400, Michael S. Tsirkin wrote: On Tue, Oct 19, 2021 at 11:46:17AM +0100, Stefan

Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-10-19 Thread Jean-Louis Dupond
On 19/10/2021 17:27, Eduardo Habkost wrote: On Tue, Oct 12, 2021 at 10:24:28AM +0200, Jean-Louis Dupond wrote: hw_compat modes only take into account their base name. What do you mean by "base name"? virtio-net-pci (without the (non-)transitional extension. But if a device is created with (no

Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-10-19 Thread Jason Wang
On Wed, Oct 20, 2021 at 9:31 AM Jason Wang wrote: > > On Wed, Oct 20, 2021 at 12:56 AM Eduardo Habkost wrote: > > > > On Tue, Oct 19, 2021 at 12:13:17PM -0400, Michael S. Tsirkin wrote: > > > On Tue, Oct 19, 2021 at 11:29:13AM -0400, Eduardo Habkost wrote: > > > > On Tue, Oct 19, 2021 at 06:59:09

Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-10-19 Thread Jason Wang
On Wed, Oct 20, 2021 at 12:56 AM Eduardo Habkost wrote: > > On Tue, Oct 19, 2021 at 12:13:17PM -0400, Michael S. Tsirkin wrote: > > On Tue, Oct 19, 2021 at 11:29:13AM -0400, Eduardo Habkost wrote: > > > On Tue, Oct 19, 2021 at 06:59:09AM -0400, Michael S. Tsirkin wrote: > > > > On Tue, Oct 19, 202

Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-10-19 Thread Michael S. Tsirkin
On Tue, Oct 19, 2021 at 11:29:13AM -0400, Eduardo Habkost wrote: > On Tue, Oct 19, 2021 at 06:59:09AM -0400, Michael S. Tsirkin wrote: > > On Tue, Oct 19, 2021 at 11:46:17AM +0100, Stefan Hajnoczi wrote: > > > On Tue, Oct 12, 2021 at 10:36:01AM +0200, Jean-Louis Dupond wrote: > > > > Forgot to CC m

Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-10-19 Thread Eduardo Habkost
On Tue, Oct 19, 2021 at 12:13:17PM -0400, Michael S. Tsirkin wrote: > On Tue, Oct 19, 2021 at 11:29:13AM -0400, Eduardo Habkost wrote: > > On Tue, Oct 19, 2021 at 06:59:09AM -0400, Michael S. Tsirkin wrote: > > > On Tue, Oct 19, 2021 at 11:46:17AM +0100, Stefan Hajnoczi wrote: > > > > On Tue, Oct 1

Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-10-19 Thread Eduardo Habkost
On Tue, Oct 19, 2021 at 06:59:09AM -0400, Michael S. Tsirkin wrote: > On Tue, Oct 19, 2021 at 11:46:17AM +0100, Stefan Hajnoczi wrote: > > On Tue, Oct 12, 2021 at 10:36:01AM +0200, Jean-Louis Dupond wrote: > > > Forgot to CC maintainers. > > > > Also CCing Jason Wang and Michael Tsirkin for VIRTIO

Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-10-19 Thread Eduardo Habkost
On Tue, Oct 12, 2021 at 10:24:28AM +0200, Jean-Louis Dupond wrote: > hw_compat modes only take into account their base name. What do you mean by "base name"? > But if a device is created with (non)-transitional, then the compat > values are not used, causing migrating issues. > > This commit add

Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-10-19 Thread Michael S. Tsirkin
On Tue, Oct 19, 2021 at 11:46:17AM +0100, Stefan Hajnoczi wrote: > On Tue, Oct 12, 2021 at 10:36:01AM +0200, Jean-Louis Dupond wrote: > > Forgot to CC maintainers. > > Also CCing Jason Wang and Michael Tsirkin for VIRTIO. > > Stefan OMG where all compat properties broken all the time? > > > >

Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-10-19 Thread Stefan Hajnoczi
On Tue, Oct 12, 2021 at 10:36:01AM +0200, Jean-Louis Dupond wrote: > Forgot to CC maintainers. Also CCing Jason Wang and Michael Tsirkin for VIRTIO. Stefan > > On 12/10/2021 10:24, Jean-Louis Dupond wrote: > > hw_compat modes only take into account their base name. > > But if a device is create

Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-10-12 Thread Jean-Louis Dupond
Forgot to CC maintainers. On 12/10/2021 10:24, Jean-Louis Dupond wrote: hw_compat modes only take into account their base name. But if a device is created with (non)-transitional, then the compat values are not used, causing migrating issues. This commit adds their (non)-transitional entries wi

[PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-10-12 Thread Jean-Louis Dupond
hw_compat modes only take into account their base name. But if a device is created with (non)-transitional, then the compat values are not used, causing migrating issues. This commit adds their (non)-transitional entries with the same settings as the base entry. Fixes https://bugzilla.redhat.com/

[PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

2021-10-12 Thread Jean-Louis Dupond
hw_compat modes only take into account their base name. But if a device is created with (non)-transitional, then the compat values are not used, causing migrating issues. This commit adds their (non)-transitional entries with the same settings as the base entry. Fixes https://bugzilla.redhat.com/