Re: [PATCH] hw/rtc/m48t59: Simplify m48t59_init()

2020-10-12 Thread Laurent Vivier
Le 30/09/2020 à 13:25, Laurent Vivier a écrit : > Le 14/09/2020 à 12:24, Philippe Mathieu-Daudé a écrit : >> As the 'io_base' argument of m48t59_init() is unused (set to 0), >> remove it to simplify. >> To create a device on the ISA bus, m48t59_init_isa() is the >> preferred function to use. >> >>

Re: [PATCH] hw/rtc/m48t59: Simplify m48t59_init()

2020-09-30 Thread Laurent Vivier
Le 14/09/2020 à 12:24, Philippe Mathieu-Daudé a écrit : > As the 'io_base' argument of m48t59_init() is unused (set to 0), > remove it to simplify. > To create a device on the ISA bus, m48t59_init_isa() is the > preferred function to use. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include

Re: [PATCH] hw/rtc/m48t59: Simplify m48t59_init()

2020-09-30 Thread Philippe Mathieu-Daudé
On 9/30/20 10:35 AM, Mark Cave-Ayland wrote: > On 14/09/2020 11:24, Philippe Mathieu-Daudé wrote: > >> As the 'io_base' argument of m48t59_init() is unused (set to 0), >> remove it to simplify. >> To create a device on the ISA bus, m48t59_init_isa() is the >> preferred function to use. >> >> Signe

Re: [PATCH] hw/rtc/m48t59: Simplify m48t59_init()

2020-09-30 Thread Mark Cave-Ayland
On 14/09/2020 11:24, Philippe Mathieu-Daudé wrote: > As the 'io_base' argument of m48t59_init() is unused (set to 0), > remove it to simplify. > To create a device on the ISA bus, m48t59_init_isa() is the > preferred function to use. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/

Re: [PATCH] hw/rtc/m48t59: Simplify m48t59_init()

2020-09-30 Thread Mark Cave-Ayland
On 24/09/2020 16:00, Laurent Vivier wrote: > Le 24/09/2020 à 16:53, Philippe Mathieu-Daudé a écrit : >> On 9/16/20 4:50 AM, David Gibson wrote: >>> On Mon, Sep 14, 2020 at 12:24:25PM +0200, Philippe Mathieu-Daudé wrote: As the 'io_base' argument of m48t59_init() is unused (set to 0), rem

Re: [PATCH] hw/rtc/m48t59: Simplify m48t59_init()

2020-09-29 Thread Philippe Mathieu-Daudé
On 9/24/20 5:00 PM, Laurent Vivier wrote: > Le 24/09/2020 à 16:53, Philippe Mathieu-Daudé a écrit : >> On 9/16/20 4:50 AM, David Gibson wrote: >>> On Mon, Sep 14, 2020 at 12:24:25PM +0200, Philippe Mathieu-Daudé wrote: As the 'io_base' argument of m48t59_init() is unused (set to 0), remov

Re: [PATCH] hw/rtc/m48t59: Simplify m48t59_init()

2020-09-24 Thread Laurent Vivier
Le 24/09/2020 à 16:53, Philippe Mathieu-Daudé a écrit : > On 9/16/20 4:50 AM, David Gibson wrote: >> On Mon, Sep 14, 2020 at 12:24:25PM +0200, Philippe Mathieu-Daudé wrote: >>> As the 'io_base' argument of m48t59_init() is unused (set to 0), >>> remove it to simplify. >>> To create a device on the

Re: [PATCH] hw/rtc/m48t59: Simplify m48t59_init()

2020-09-24 Thread Philippe Mathieu-Daudé
On 9/16/20 4:50 AM, David Gibson wrote: > On Mon, Sep 14, 2020 at 12:24:25PM +0200, Philippe Mathieu-Daudé wrote: >> As the 'io_base' argument of m48t59_init() is unused (set to 0), >> remove it to simplify. >> To create a device on the ISA bus, m48t59_init_isa() is the >> preferred function to use

Re: [PATCH] hw/rtc/m48t59: Simplify m48t59_init()

2020-09-16 Thread David Gibson
On Mon, Sep 14, 2020 at 12:24:25PM +0200, Philippe Mathieu-Daudé wrote: > As the 'io_base' argument of m48t59_init() is unused (set to 0), > remove it to simplify. > To create a device on the ISA bus, m48t59_init_isa() is the > preferred function to use. > > Signed-off-by: Philippe Mathieu-Daudé

[PATCH] hw/rtc/m48t59: Simplify m48t59_init()

2020-09-14 Thread Philippe Mathieu-Daudé
As the 'io_base' argument of m48t59_init() is unused (set to 0), remove it to simplify. To create a device on the ISA bus, m48t59_init_isa() is the preferred function to use. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/rtc/m48t59.h | 2 +- hw/ppc/ppc405_boards.c | 2 +- hw/rtc/m48t59