Re: [PATCH] hw/s390x: Include missing 'cpu.h' header

2024-04-16 Thread Philippe Mathieu-Daudé
On 22/3/24 17:28, Philippe Mathieu-Daudé wrote: "cpu.h" is implicitly included. Include it explicitly to avoid the following error when refactoring headers: hw/s390x/s390-stattrib.c:86:40: error: use of undeclared identifier 'TARGET_PAGE_SIZE' len = sac->peek_stattr(sas, addr / TARGET

Re: [PATCH] hw/s390x: Include missing 'cpu.h' header

2024-03-25 Thread Eric Farman
On Fri, 2024-03-22 at 17:28 +0100, Philippe Mathieu-Daudé wrote: > "cpu.h" is implicitly included. Include it explicitly to > avoid the following error when refactoring headers: > >   hw/s390x/s390-stattrib.c:86:40: error: use of undeclared identifier > 'TARGET_PAGE_SIZE' >   len = sac->peek_s

Re: [PATCH] hw/s390x: Include missing 'cpu.h' header

2024-03-25 Thread Thomas Huth
On 22/03/2024 17.28, Philippe Mathieu-Daudé wrote: "cpu.h" is implicitly included. Include it explicitly to avoid the following error when refactoring headers: hw/s390x/s390-stattrib.c:86:40: error: use of undeclared identifier 'TARGET_PAGE_SIZE' len = sac->peek_stattr(sas, addr / TAR

[PATCH] hw/s390x: Include missing 'cpu.h' header

2024-03-22 Thread Philippe Mathieu-Daudé
"cpu.h" is implicitly included. Include it explicitly to avoid the following error when refactoring headers: hw/s390x/s390-stattrib.c:86:40: error: use of undeclared identifier 'TARGET_PAGE_SIZE' len = sac->peek_stattr(sas, addr / TARGET_PAGE_SIZE, buflen, vals);