Re: [PATCH] hw/sparc/leon3: Fix wrong usage of DO_UPCAST macro

2024-02-22 Thread Philippe Mathieu-Daudé
On 22/2/24 09:26, Clément Chigot wrote: Hi Philippe, Thomas Thanks for handling that ! And I do confirm that it does not trigger any obvious regression on our side. Since I screwed my hw-misc pull request, I'll add your Tested-by to the commit before respin. Thanks, Clément On Thu, Feb

Re: [PATCH] hw/sparc/leon3: Fix wrong usage of DO_UPCAST macro

2024-02-22 Thread Clément Chigot
Hi Philippe, Thomas Thanks for handling that ! And I do confirm that it does not trigger any obvious regression on our side. Thanks, Clément On Thu, Feb 22, 2024 at 8:46 AM Philippe Mathieu-Daudé wrote: > > On 21/2/24 19:49, Philippe Mathieu-Daudé wrote: > > On 21/2/24 19:47, Philippe

Re: [PATCH] hw/sparc/leon3: Fix wrong usage of DO_UPCAST macro

2024-02-21 Thread Philippe Mathieu-Daudé
On 21/2/24 19:49, Philippe Mathieu-Daudé wrote: On 21/2/24 19:47, Philippe Mathieu-Daudé wrote: On 21/2/24 19:07, Thomas Huth wrote: leon3.c currently fails to compile with some compilers when the -Wvla option has been enabled:   ../hw/sparc/leon3.c: In function ‘leon3_cpu_reset’:  

Re: [PATCH] hw/sparc/leon3: Fix wrong usage of DO_UPCAST macro

2024-02-21 Thread Philippe Mathieu-Daudé
On 21/2/24 19:47, Philippe Mathieu-Daudé wrote: On 21/2/24 19:07, Thomas Huth wrote: leon3.c currently fails to compile with some compilers when the -Wvla option has been enabled:   ../hw/sparc/leon3.c: In function ‘leon3_cpu_reset’:   ../hw/sparc/leon3.c:153:5: error: ISO C90 forbids variable

Re: [PATCH] hw/sparc/leon3: Fix wrong usage of DO_UPCAST macro

2024-02-21 Thread Philippe Mathieu-Daudé
On 21/2/24 19:07, Thomas Huth wrote: leon3.c currently fails to compile with some compilers when the -Wvla option has been enabled: ../hw/sparc/leon3.c: In function ‘leon3_cpu_reset’: ../hw/sparc/leon3.c:153:5: error: ISO C90 forbids variable length array ‘offset_must_be_zero’

[PATCH] hw/sparc/leon3: Fix wrong usage of DO_UPCAST macro

2024-02-21 Thread Thomas Huth
leon3.c currently fails to compile with some compilers when the -Wvla option has been enabled: ../hw/sparc/leon3.c: In function ‘leon3_cpu_reset’: ../hw/sparc/leon3.c:153:5: error: ISO C90 forbids variable length array ‘offset_must_be_zero’ [-Werror=vla] 153 | ResetData *s = (ResetData