Re: [PATCH] hw/timer/hpet: Fix wrong HPET interrupts

2024-07-13 Thread 伊藤 太清
件名: Re: [PATCH] hw/timer/hpet: Fix wrong HPET interrupts Hello! Thanks for looking after the HPET, which is not a very well maintained device. I am not sure your patch needs to mask the comparator with timer->cmp &= 0xULL; I think that's a bug in the "case HPET_TN_C

Re: [PATCH] hw/timer/hpet: Fix wrong HPET interrupts

2024-07-10 Thread Paolo Bonzini
Hello! Thanks for looking after the HPET, which is not a very well maintained device. I am not sure your patch needs to mask the comparator with timer->cmp &= 0xULL; I think that's a bug in the "case HPET_TN_CMP + 4" part of hpet_ram_write. The logic was changed in "hpet: Fix

Re: [PATCH] hw/timer/hpet: Fix wrong HPET interrupts

2024-07-04 Thread Michael S. Tsirkin
On Tue, Jun 18, 2024 at 01:10:44PM +, TaiseiIto wrote: > Before this commit, there are 3 problems about HPET timer interrupts. First, > HPET periodic timers cause a too early interrupt before HPET main counter > value reaches a value written its comparator value register. Second, > disabled

Re: [PATCH] hw/timer/hpet: Fix wrong HPET interrupts

2024-07-04 Thread Alex Bennée
TaiseiIto writes: (widen CC list to include machine pc maintainers which use HPET) > Before this commit, there are 3 problems about HPET timer interrupts. First, > HPET periodic timers cause a too early interrupt before HPET main counter > value reaches a value written its comparator value

[PING][PATCH] hw/timer/hpet: Fix wrong HPET interrupts

2024-07-04 Thread 伊藤 太清
...@redhat.com ; TaiseiIto 件名: [PATCH] hw/timer/hpet: Fix wrong HPET interrupts Before this commit, there are 3 problems about HPET timer interrupts. First, HPET periodic timers cause a too early interrupt before HPET main counter value reaches a value written its comparator value register. Second, disabled

[PATCH] hw/timer/hpet: Fix wrong HPET interrupts

2024-06-18 Thread TaiseiIto
Before this commit, there are 3 problems about HPET timer interrupts. First, HPET periodic timers cause a too early interrupt before HPET main counter value reaches a value written its comparator value register. Second, disabled HPET timers whose comparator value register is not 0x