Re: [PATCH] hw/tpm: TIS on sysbus: Remove unsupport ppi command line option

2023-07-14 Thread Stefan Berger
On 7/14/23 09:51, Eric Auger wrote: Hi Stefan, On 7/14/23 13:51, Stefan Berger wrote: On 7/14/23 02:07, Joelle van Dyne wrote: On Thu, Jul 13, 2023 at 10:20 AM Stefan Berger wrote: The ppi command line option for the TIS device on sysbus never worked and caused an immediate segfault. Re

Re: [PATCH] hw/tpm: TIS on sysbus: Remove unsupport ppi command line option

2023-07-14 Thread Eric Auger
Hi Stefan, On 7/14/23 13:51, Stefan Berger wrote: > > > On 7/14/23 02:07, Joelle van Dyne wrote: >> On Thu, Jul 13, 2023 at 10:20 AM Stefan Berger >> wrote: >>> >>> The ppi command line option for the TIS device on sysbus never worked >>> and caused an immediate segfault. Remove support for it sin

Re: [PATCH] hw/tpm: TIS on sysbus: Remove unsupport ppi command line option

2023-07-14 Thread Stefan Berger
On 7/14/23 02:07, Joelle van Dyne wrote: On Thu, Jul 13, 2023 at 10:20 AM Stefan Berger wrote: The ppi command line option for the TIS device on sysbus never worked and caused an immediate segfault. Remove support for it since it also needs support in the firmware and needs testing inside t

[PATCH] hw/tpm: TIS on sysbus: Remove unsupport ppi command line option

2023-07-14 Thread Stefan Berger
The ppi command line option for the TIS device on sysbus never worked and caused an immediate segfault. Since it is part of the state of a VM we cannot remove it but have to intercept ppi_enabled set to true and display an error instead. Reproducer with the ppi=on option passed: qemu-system-aarch

Re: [PATCH] hw/tpm: TIS on sysbus: Remove unsupport ppi command line option

2023-07-13 Thread Joelle van Dyne
On Thu, Jul 13, 2023 at 11:07 PM Joelle van Dyne wrote: > > On Thu, Jul 13, 2023 at 10:20 AM Stefan Berger wrote: > > > > The ppi command line option for the TIS device on sysbus never worked > > and caused an immediate segfault. Remove support for it since it also > > needs support in the firmwa

Re: [PATCH] hw/tpm: TIS on sysbus: Remove unsupport ppi command line option

2023-07-13 Thread Joelle van Dyne
On Thu, Jul 13, 2023 at 10:20 AM Stefan Berger wrote: > > The ppi command line option for the TIS device on sysbus never worked > and caused an immediate segfault. Remove support for it since it also > needs support in the firmware and needs testing inside the VM. > > Reproducer with the ppi=on op

Re: [PATCH] hw/tpm: TIS on sysbus: Remove unsupport ppi command line option

2023-07-13 Thread Eric Auger
Hi Stefan, On 7/13/23 19:19, Stefan Berger wrote: > The ppi command line option for the TIS device on sysbus never worked > and caused an immediate segfault. Remove support for it since it also > needs support in the firmware and needs testing inside the VM. > > Reproducer with the ppi=on option p

[PATCH] hw/tpm: TIS on sysbus: Remove unsupport ppi command line option

2023-07-13 Thread Stefan Berger
The ppi command line option for the TIS device on sysbus never worked and caused an immediate segfault. Remove support for it since it also needs support in the firmware and needs testing inside the VM. Reproducer with the ppi=on option passed: qemu-system-aarch64 \ -machine virt,gic-version=3