Re: [PATCH] i2c: Match parameters of i2c_start_transfer and i2c_send_recv

2020-06-26 Thread Fred Konrad
Hi Corey, Le 6/22/20 à 11:32 PM, Corey Minyard a écrit : On Sun, Jun 21, 2020 at 04:43:38PM +0200, BALATON Zoltan wrote: These functions have a parameter that decides the direction of transfer but totally confusingly they don't match but inverted sense. To avoid frequent mistakes when using t

Re: [PATCH] i2c: Match parameters of i2c_start_transfer and i2c_send_recv

2020-06-22 Thread Philippe Mathieu-Daudé
On Mon, Jun 22, 2020 at 11:34 PM Corey Minyard wrote: > On Sun, Jun 21, 2020 at 04:43:38PM +0200, BALATON Zoltan wrote: > > These functions have a parameter that decides the direction of > > transfer but totally confusingly they don't match but inverted sense. > > To avoid frequent mistakes when u

Re: [PATCH] i2c: Match parameters of i2c_start_transfer and i2c_send_recv

2020-06-22 Thread Philippe Mathieu-Daudé
On Tue, Jun 23, 2020 at 7:15 AM Philippe Mathieu-Daudé wrote: > On 6/23/20 4:06 AM, Corey Minyard wrote: > > On Mon, Jun 22, 2020 at 04:32:37PM -0500, Corey Minyard wrote: > >> On Sun, Jun 21, 2020 at 04:43:38PM +0200, BALATON Zoltan wrote: > >>> These functions have a parameter that decides the d

Re: [PATCH] i2c: Match parameters of i2c_start_transfer and i2c_send_recv

2020-06-22 Thread Philippe Mathieu-Daudé
On 6/23/20 4:06 AM, Corey Minyard wrote: > On Mon, Jun 22, 2020 at 04:32:37PM -0500, Corey Minyard wrote: >> On Sun, Jun 21, 2020 at 04:43:38PM +0200, BALATON Zoltan wrote: >>> These functions have a parameter that decides the direction of >>> transfer but totally confusingly they don't match but i

Re: [PATCH] i2c: Match parameters of i2c_start_transfer and i2c_send_recv

2020-06-22 Thread Corey Minyard
On Mon, Jun 22, 2020 at 04:32:37PM -0500, Corey Minyard wrote: > On Sun, Jun 21, 2020 at 04:43:38PM +0200, BALATON Zoltan wrote: > > These functions have a parameter that decides the direction of > > transfer but totally confusingly they don't match but inverted sense. > > To avoid frequent mistake

Re: [PATCH] i2c: Match parameters of i2c_start_transfer and i2c_send_recv

2020-06-22 Thread Corey Minyard
On Sun, Jun 21, 2020 at 04:43:38PM +0200, BALATON Zoltan wrote: > These functions have a parameter that decides the direction of > transfer but totally confusingly they don't match but inverted sense. > To avoid frequent mistakes when using these functions change > i2c_send_recv to match i2c_start_

[PATCH] i2c: Match parameters of i2c_start_transfer and i2c_send_recv

2020-06-21 Thread BALATON Zoltan
These functions have a parameter that decides the direction of transfer but totally confusingly they don't match but inverted sense. To avoid frequent mistakes when using these functions change i2c_send_recv to match i2c_start_transfer. Also use bool in i2c_start_transfer instead of int to match i2