Re: [PATCH] i386/xen: consistent locking around Xen singleshot timers

2023-07-04 Thread David Woodhouse
On Fri, 2023-06-02 at 17:58 +0100, Peter Maydell wrote: > On Mon, 22 May 2023 at 19:52, David Woodhouse wrote: > > > > From: David Woodhouse > > > > Coverity points out (CID 1507534) that we sometimes access > > env->xen_singleshot_timer_ns under the protection of > > env->xen_timers_lock (eg i

Re: [PATCH] i386/xen: consistent locking around Xen singleshot timers

2023-06-02 Thread Peter Maydell
On Mon, 22 May 2023 at 19:52, David Woodhouse wrote: > > From: David Woodhouse > > Coverity points out (CID 1507534) that we sometimes access > env->xen_singleshot_timer_ns under the protection of > env->xen_timers_lock (eg in xen_vcpu_singleshot_timer_event()) and > sometimes not (the specific c

Re: [PATCH] i386/xen: consistent locking around Xen singleshot timers

2023-05-23 Thread Paul Durrant
On 22/05/2023 19:52, David Woodhouse wrote: From: David Woodhouse Coverity points out (CID 1507534) that we sometimes access env->xen_singleshot_timer_ns under the protection of env->xen_timers_lock (eg in xen_vcpu_singleshot_timer_event()) and sometimes not (the specific case Coverity complain

[PATCH] i386/xen: consistent locking around Xen singleshot timers

2023-05-22 Thread David Woodhouse
From: David Woodhouse Coverity points out (CID 1507534) that we sometimes access env->xen_singleshot_timer_ns under the protection of env->xen_timers_lock (eg in xen_vcpu_singleshot_timer_event()) and sometimes not (the specific case Coverity complains about is in do_vcpu_soft_reset()). This isn