Re: [PATCH] i386: Re-add "pconfig" CPUID flag name

2019-09-27 Thread Eduardo Habkost
On Fri, Sep 27, 2019 at 10:09:05AM +0100, Daniel P. Berrangé wrote: > On Thu, Sep 26, 2019 at 09:42:20PM -0300, Eduardo Habkost wrote: > > (CCing libvir-list) > > > > On Thu, Sep 26, 2019 at 11:58:30PM +0200, Paolo Bonzini wrote: > > > Is this really needed? QEMU's value of pconfig=on vs. off shou

Re: [PATCH] i386: Re-add "pconfig" CPUID flag name

2019-09-27 Thread Daniel P . Berrangé
On Thu, Sep 26, 2019 at 09:42:20PM -0300, Eduardo Habkost wrote: > (CCing libvir-list) > > On Thu, Sep 26, 2019 at 11:58:30PM +0200, Paolo Bonzini wrote: > > Is this really needed? QEMU's value of pconfig=on vs. off should be > > provided by QMP CPU model queries, if a property is not available th

Re: [PATCH] i386: Re-add "pconfig" CPUID flag name

2019-09-26 Thread Eduardo Habkost
(CCing libvir-list) On Thu, Sep 26, 2019 at 11:58:30PM +0200, Paolo Bonzini wrote: > Is this really needed? QEMU's value of pconfig=on vs. off should be > provided by QMP CPU model queries, if a property is not available then > Libvirt should not try to set it to off. > Libvirt can easily work a

Re: [PATCH] i386: Re-add "pconfig" CPUID flag name

2019-09-26 Thread Paolo Bonzini
Is this really needed? QEMU's value of pconfig=on vs. off should be provided by QMP CPU model queries, if a property is not available then Libvirt should not try to set it to off. Paolo Il gio 26 set 2019, 23:23 Eduardo Habkost ha scritto: > QEMU 3.1.0 was shipped with the "pconfig" CPU propert

Re: [PATCH] i386: Re-add "pconfig" CPUID flag name

2019-09-26 Thread Eduardo Habkost
On Thu, Sep 26, 2019 at 06:23:26PM -0300, Eduardo Habkost wrote: > QEMU 3.1.0 was shipped with the "pconfig" CPU property available, > added by commit 5131dc433df5 ("i386: Add CPUID bit for PCONFIG"). > > Then the feature was removed in QEMU 4.0.0 (and 3.1.1), by commit > 712f807e1965 ("Revert 'i3

[PATCH] i386: Re-add "pconfig" CPUID flag name

2019-09-26 Thread Eduardo Habkost
QEMU 3.1.0 was shipped with the "pconfig" CPU property available, added by commit 5131dc433df5 ("i386: Add CPUID bit for PCONFIG"). Then the feature was removed in QEMU 4.0.0 (and 3.1.1), by commit 712f807e1965 ("Revert 'i386: Add CPUID bit for PCONFIG'"). In theory this would be OK, but we do ha