Re: [PATCH] iothread: Set the GSource "name" field

2023-09-05 Thread Stefan Hajnoczi
On Tue, 5 Sept 2023 at 12:51, Philippe Mathieu-Daudé wrote: > > On 5/9/23 17:45, Peter Xu wrote: > > On Mon, Sep 04, 2023 at 11:48:11AM -0300, Fabiano Rosas wrote: > >> @@ -189,11 +193,14 @@ static void iothread_init(EventLoopBase *base, Error > >> **errp) > >> return; > >> } > >>

Re: [PATCH] iothread: Set the GSource "name" field

2023-09-05 Thread Philippe Mathieu-Daudé
On 5/9/23 17:45, Peter Xu wrote: On Mon, Sep 04, 2023 at 11:48:11AM -0300, Fabiano Rosas wrote: @@ -189,11 +193,14 @@ static void iothread_init(EventLoopBase *base, Error **errp) return; } +thread_name = g_strdup_printf("IO %s", +object_get_canoni

Re: [PATCH] iothread: Set the GSource "name" field

2023-09-05 Thread Peter Xu
On Mon, Sep 04, 2023 at 11:48:11AM -0300, Fabiano Rosas wrote: > @@ -189,11 +193,14 @@ static void iothread_init(EventLoopBase *base, Error > **errp) > return; > } > > +thread_name = g_strdup_printf("IO %s", > +object_get_canonical_path_component(OBJECT(

Re: [PATCH] iothread: Set the GSource "name" field

2023-09-04 Thread Philippe Mathieu-Daudé
On 4/9/23 16:48, Fabiano Rosas wrote: Having a name in the source helps with debugging core dumps when one might not have access to TLS data to cross-reference AioContexts with their addresses. Signed-off-by: Fabiano Rosas --- iothread.c | 13 + 1 file changed, 9 insertions(+), 4

[PATCH] iothread: Set the GSource "name" field

2023-09-04 Thread Fabiano Rosas
Having a name in the source helps with debugging core dumps when one might not have access to TLS data to cross-reference AioContexts with their addresses. Signed-off-by: Fabiano Rosas --- iothread.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/iothread.c b/i