Re: [PATCH] linux-user/riscv: fix up struct target_ucontext definition

2020-04-23 Thread Richard Henderson
On 4/22/20 6:55 PM, LIU Zhiwei wrote: > As far as I know, Guo Ren and Greentime are supporting RVV on Linux, based on > the v0.7.1 QEMU implementation. > The main problem is that VLEN is not a  fixed number. Neither is the SVE vector length fixed. That's one of the reasons I pointed you at the AA

Re: [PATCH] linux-user/riscv: fix up struct target_ucontext definition

2020-04-22 Thread LIU Zhiwei
On 2020/4/22 12:10, Richard Henderson wrote: On 4/21/20 7:34 PM, LIU Zhiwei wrote: Ping. When I port RISU, I find this bug. I can't get the correct registers from the struct ucontext_t parameter in the signal handler. The RISC-V Linux ABI will need to be extended to handle RVV state. There

Re: [PATCH] linux-user/riscv: fix up struct target_ucontext definition

2020-04-22 Thread Alistair Francis
On Wed, Apr 22, 2020 at 12:20 PM Richard Henderson wrote: > > On 4/22/20 11:05 AM, Alistair Francis wrote: > > Just to clarify, this patch is still correct right? > > Yes. That's what I thought. Thanks :) Applied to the RISC-V tree for 5.1. Alistair > > > r~

Re: [PATCH] linux-user/riscv: fix up struct target_ucontext definition

2020-04-22 Thread Richard Henderson
On 4/22/20 11:05 AM, Alistair Francis wrote: > Just to clarify, this patch is still correct right? Yes. r~

Re: [PATCH] linux-user/riscv: fix up struct target_ucontext definition

2020-04-22 Thread Alistair Francis
On Tue, Apr 21, 2020 at 9:10 PM Richard Henderson wrote: > > On 4/21/20 7:34 PM, LIU Zhiwei wrote: > > Ping. > > > > When I port RISU, I find this bug. I can't get the correct registers from > > the > > struct ucontext_t parameter in the signal handler. > > The RISC-V Linux ABI will need to be ex

Re: [PATCH] linux-user/riscv: fix up struct target_ucontext definition

2020-04-21 Thread Richard Henderson
On 4/21/20 7:34 PM, LIU Zhiwei wrote: > Ping. > > When I port RISU, I find this bug. I can't get the correct registers from the > struct ucontext_t parameter in the signal handler. The RISC-V Linux ABI will need to be extended to handle RVV state. There is room in your sigcontext structure: > s

Re: [PATCH] linux-user/riscv: fix up struct target_ucontext definition

2020-04-21 Thread LIU Zhiwei
Ping. When I port RISU, I find this bug. I can't get the correct registers from the struct ucontext_t parameter in the signal handler. If you want to reproduce it, just   register a signal handler for SIGILL, and  output an illegal instruction, such as #include #include #include #include

[PATCH] linux-user/riscv: fix up struct target_ucontext definition

2020-04-11 Thread LIU Zhiwei
As struct target_ucontext will be transfered to signal handler, it must keep pace with struct ucontext_t defined in Linux kernel. Signed-off-by: LIU Zhiwei --- linux-user/riscv/signal.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/linux-user/riscv/signal.c b/linux-user/r