Re: [PATCH] linux-user/strace: Improve output of various syscalls

2019-11-20 Thread Aleksandar Markovic
On Wed, Nov 20, 2019 at 9:57 PM Aleksandar Markovic wrote: > > On Tue, Nov 19, 2019 at 8:05 PM Helge Deller wrote: > > > > Improve strace output of various syscalls which either have none > > or only int-type parameters. > > > > Signed-off-by: Helge Deller > > > > A very good patch! > > It would

Re: [PATCH] linux-user/strace: Improve output of various syscalls

2019-11-20 Thread Aleksandar Markovic
On Tue, Nov 19, 2019 at 8:05 PM Helge Deller wrote: > > Improve strace output of various syscalls which either have none > or only int-type parameters. > > Signed-off-by: Helge Deller > A very good patch! It would be even better if it covered ALL syscalls either without parameter or with all in

Re: [PATCH] linux-user/strace: Improve output of various syscalls

2019-11-20 Thread Aleksandar Markovic
> @@ -26,7 +26,7 @@ > { TARGET_NR_afs_syscall, "afs_syscall" , NULL, NULL, NULL }, > #endif > #ifdef TARGET_NR_alarm > -{ TARGET_NR_alarm, "alarm" , NULL, NULL, NULL }, > +{ TARGET_NR_alarm, "alarm" , "%s(%d)", NULL, NULL }, > #endif Man page says: unsigned int alarm(unsigned int seconds) Th

Re: [PATCH] linux-user/strace: Improve output of various syscalls

2019-11-19 Thread Aleksandar Markovic
> > #ifdef TARGET_NR_ioctl > -{ TARGET_NR_ioctl, "ioctl" , NULL, NULL, NULL }, > +{ TARGET_NR_ioctl, "ioctl" , "%s(%d,%#x,%#x,%#x,%#x,%#x)", NULL, NULL }, > #endif ioctl() has only three arguments. Regards, Aleksandar

[PATCH] linux-user/strace: Improve output of various syscalls

2019-11-19 Thread Helge Deller
Improve strace output of various syscalls which either have none or only int-type parameters. Signed-off-by: Helge Deller diff --git a/linux-user/strace.list b/linux-user/strace.list index 1de4319dcf..5163717087 100644 --- a/linux-user/strace.list +++ b/linux-user/strace.list @@ -26,7 +26,7 @@