Re: [PATCH] mark with for-crc32 in a consistent manner

2024-08-29 Thread Michael Tokarev
29.08.2024 10:52, Michael Tokarev wrote: ... This is a resent which shouldn't be here (a forgotten 0001-foo.patch in the working dir). Please ignore :) /mjt

[PATCH] mark with for-crc32 in a consistent manner

2024-08-29 Thread Michael Tokarev
in many cases, is only included for crc32 function, and in some of them, there's a comment saying that, but in a different way. In one place (hw/net/rtl8139.c), there was another #include added between the comment and include. Make all such comments to be on the same line as #include, make it c

Re: [PATCH] mark with for-crc32 in a consistent manner

2024-08-28 Thread Mark Cave-Ayland
On 27/08/2024 18:51, Michael Tokarev wrote: 27.08.2024 15:09, Mark Cave-Ayland wrote: On 27/08/2024 11:02, Michael Tokarev wrote: in many cases, is only included for crc32 function, and in some of them, there's a comment saying that, but in a different way.  In one place (hw/net/rtl8139.c),

Re: [PATCH] mark with for-crc32 in a consistent manner

2024-08-27 Thread Michael Tokarev
27.08.2024 15:09, Mark Cave-Ayland wrote: On 27/08/2024 11:02, Michael Tokarev wrote: in many cases, is only included for crc32 function, and in some of them, there's a comment saying that, but in a different way.  In one place (hw/net/rtl8139.c), there was another #include added between the c

Re: [PATCH] mark with for-crc32 in a consistent manner

2024-08-27 Thread Mark Cave-Ayland
On 27/08/2024 11:02, Michael Tokarev wrote: in many cases, is only included for crc32 function, and in some of them, there's a comment saying that, but in a different way. In one place (hw/net/rtl8139.c), there was another #include added between the comment and include. Make all such comment

Re: [PATCH] mark with for-crc32 in a consistent manner

2024-08-27 Thread Philippe Mathieu-Daudé
+Richard On 27/8/24 12:02, Michael Tokarev wrote: in many cases, is only included for crc32 function, and in some of them, there's a comment saying that, but in a different way. In one place (hw/net/rtl8139.c), there was another #include added between the comment and include. Make all such c

[PATCH] mark with for-crc32 in a consistent manner

2024-08-27 Thread Michael Tokarev
in many cases, is only included for crc32 function, and in some of them, there's a comment saying that, but in a different way. In one place (hw/net/rtl8139.c), there was another #include added between the comment and include. Make all such comments to be on the same line as #include, make it c