Re: [PATCH] memory: Replace DEBUG_UNASSIGNED printf calls by trace events

2019-10-08 Thread Alistair Francis
On Tue, Oct 8, 2019 at 1:41 PM Alistair Francis wrote: > > On Tue, Oct 8, 2019 at 1:41 PM Palmer Dabbelt wrote: > > > > On Fri, 20 Sep 2019 07:20:34 PDT (-0700), Peter Maydell wrote: > > > On Fri, 20 Sep 2019 at 15:17, Paolo Bonzini wrote: > > >> I think it's simplest if all series (RISC-V, remo

Re: [PATCH] memory: Replace DEBUG_UNASSIGNED printf calls by trace events

2019-10-08 Thread Alistair Francis
On Tue, Oct 8, 2019 at 1:41 PM Palmer Dabbelt wrote: > > On Fri, 20 Sep 2019 07:20:34 PDT (-0700), Peter Maydell wrote: > > On Fri, 20 Sep 2019 at 15:17, Paolo Bonzini wrote: > >> I think it's simplest if all series (RISC-V, remove unassigned_access, > >> this one) go through the RISC-V tree. > >

Re: [PATCH] memory: Replace DEBUG_UNASSIGNED printf calls by trace events

2019-10-08 Thread Palmer Dabbelt
On Fri, 20 Sep 2019 07:20:34 PDT (-0700), Peter Maydell wrote: On Fri, 20 Sep 2019 at 15:17, Paolo Bonzini wrote: I think it's simplest if all series (RISC-V, remove unassigned_access, this one) go through the RISC-V tree. I don't inherently object but IME the risc-v tree tends to move compar

Re: [PATCH] memory: Replace DEBUG_UNASSIGNED printf calls by trace events

2019-09-20 Thread Philippe Mathieu-Daudé
Cc'ing Daniel and Lluís, On 9/20/19 5:01 PM, Eric Blake wrote: > On 9/20/19 9:39 AM, Philippe Mathieu-Daudé wrote: > I thought I read a comment about it between Eric/Stefan but I can't find it, maybe I dreamed it. (Cc'ed Eric). > > Not from me. But looking at scripts/tracetool/format/

Re: [PATCH] memory: Replace DEBUG_UNASSIGNED printf calls by trace events

2019-09-20 Thread Eric Blake
On 9/20/19 9:39 AM, Philippe Mathieu-Daudé wrote: >>> I thought I read a comment about it between Eric/Stefan but I can't find >>> it, maybe I dreamed it. (Cc'ed Eric). Not from me. But looking at scripts/tracetool/format/log_stap.py, I suspect the dtrace via stap backend cannot support it. Res

Re: [PATCH] memory: Replace DEBUG_UNASSIGNED printf calls by trace events

2019-09-20 Thread Peter Maydell
On Fri, 20 Sep 2019 at 15:29, Philippe Mathieu-Daudé wrote: > > On 9/20/19 4:19 PM, Peter Maydell wrote: > > On Fri, 20 Sep 2019 at 15:12, Philippe Mathieu-Daudé > > wrote: > >> > >> Now that the unassigned_access CPU hooks have been removed, > >> the unassigned_mem_read/write functions are only

Re: [PATCH] memory: Replace DEBUG_UNASSIGNED printf calls by trace events

2019-09-20 Thread Philippe Mathieu-Daudé
On 9/20/19 4:35 PM, Peter Maydell wrote: > On Fri, 20 Sep 2019 at 15:29, Philippe Mathieu-Daudé > wrote: >> >> On 9/20/19 4:19 PM, Peter Maydell wrote: >>> On Fri, 20 Sep 2019 at 15:12, Philippe Mathieu-Daudé >>> wrote: Now that the unassigned_access CPU hooks have been removed,

Re: [PATCH] memory: Replace DEBUG_UNASSIGNED printf calls by trace events

2019-09-20 Thread Philippe Mathieu-Daudé
On 9/20/19 4:19 PM, Peter Maydell wrote: > On Fri, 20 Sep 2019 at 15:12, Philippe Mathieu-Daudé > wrote: >> >> Now that the unassigned_access CPU hooks have been removed, >> the unassigned_mem_read/write functions are only used for >> debugging purpose. >> Simplify by converting them to in-place

Re: [PATCH] memory: Replace DEBUG_UNASSIGNED printf calls by trace events

2019-09-20 Thread Peter Maydell
On Fri, 20 Sep 2019 at 15:17, Paolo Bonzini wrote: > I think it's simplest if all series (RISC-V, remove unassigned_access, > this one) go through the RISC-V tree. I don't inherently object but IME the risc-v tree tends to move comparatively slowly. The initial risc-v conversion patchset should d

Re: [PATCH] memory: Replace DEBUG_UNASSIGNED printf calls by trace events

2019-09-20 Thread Paolo Bonzini
On 20/09/19 16:12, Philippe Mathieu-Daudé wrote: > Now that the unassigned_access CPU hooks have been removed, > the unassigned_mem_read/write functions are only used for > debugging purpose. > Simplify by converting them to in-place trace events. > > Signed-off-by: Philippe Mathieu-Daudé > --- >

Re: [PATCH] memory: Replace DEBUG_UNASSIGNED printf calls by trace events

2019-09-20 Thread Peter Maydell
On Fri, 20 Sep 2019 at 15:12, Philippe Mathieu-Daudé wrote: > > Now that the unassigned_access CPU hooks have been removed, > the unassigned_mem_read/write functions are only used for > debugging purpose. > Simplify by converting them to in-place trace events. > > Signed-off-by: Philippe Mathieu-D

[PATCH] memory: Replace DEBUG_UNASSIGNED printf calls by trace events

2019-09-20 Thread Philippe Mathieu-Daudé
Now that the unassigned_access CPU hooks have been removed, the unassigned_mem_read/write functions are only used for debugging purpose. Simplify by converting them to in-place trace events. Signed-off-by: Philippe Mathieu-Daudé --- Based-on: <20190920125008.13604-1-peter.mayd...@linaro.org> http