Re: [PATCH] meson: Clean up some dependencies regarding qemu-system

2022-12-21 Thread Helge Deller
On 12/21/22 08:49, Michael Tokarev wrote: 20.12.2022 23:56, Helge Deller wrote: .. Given that info, would it then make sense to keep as is:     --enable-system     --enable-user     --enable-tools -> qemu-bridge-helper, vhost-user-gpu, virtfs-proxy-helper, virtiofsd     --enable-guest-agent ->

Re: [PATCH] meson: Clean up some dependencies regarding qemu-system

2022-12-20 Thread Michael Tokarev
20.12.2022 23:56, Helge Deller wrote: .. Given that info, would it then make sense to keep as is:    --enable-system    --enable-user    --enable-tools -> qemu-bridge-helper, vhost-user-gpu, virtfs-proxy-helper, virtiofsd    --enable-guest-agent -> guest agents  (option is there already, but

Re: [PATCH] meson: Clean up some dependencies regarding qemu-system

2022-12-20 Thread Helge Deller
On 12/19/22 12:52, Peter Maydell wrote: On Mon, 19 Dec 2022 at 11:40, Philippe Mathieu-Daudé wrote: On 19/12/22 12:31, Peter Maydell wrote: On Mon, 19 Dec 2022 at 11:22, Helge Deller wrote: Hi Paolo, On 12/17/22 14:28, Paolo Bonzini wrote: These are wrong. qemu-bridge-helper, virtiofsd,

Re: [PATCH] meson: Clean up some dependencies regarding qemu-system

2022-12-19 Thread Alex Bennée
Helge Deller writes: > Hi Paolo, > > On 12/17/22 14:28, Paolo Bonzini wrote: >> On 12/16/22 20:07, Helge Deller wrote: >>> @@ -3581,7 +3581,7 @@ subdir('qga') >>> >>>   # Don't build qemu-keymap if xkbcommon is not explicitly enabled >>>   # when we don't build tools or system >>> -if xkbcommon

Re: [PATCH] meson: Clean up some dependencies regarding qemu-system

2022-12-19 Thread Helge Deller
On 12/19/22 12:35, Philippe Mathieu-Daudé wrote: On 16/12/22 20:07, Helge Deller wrote: Reduce amount of compiled code and installed binaries if just the qemu utilities such as qemu-img, qemu-io and qemu-nbd have to be built.  This helps to make those tools easier available on hosts where qemu-s

Re: [PATCH] meson: Clean up some dependencies regarding qemu-system

2022-12-19 Thread Peter Maydell
On Mon, 19 Dec 2022 at 11:40, Philippe Mathieu-Daudé wrote: > > On 19/12/22 12:31, Peter Maydell wrote: > > On Mon, 19 Dec 2022 at 11:22, Helge Deller wrote: > >> > >> Hi Paolo, > >> > >> On 12/17/22 14:28, Paolo Bonzini wrote: > >>> These are wrong. qemu-bridge-helper, virtiofsd, qemu-storage-d

Re: [PATCH] meson: Clean up some dependencies regarding qemu-system

2022-12-19 Thread Philippe Mathieu-Daudé
On 19/12/22 12:31, Peter Maydell wrote: On Mon, 19 Dec 2022 at 11:22, Helge Deller wrote: Hi Paolo, On 12/17/22 14:28, Paolo Bonzini wrote: These are wrong. qemu-bridge-helper, virtiofsd, qemu-storage-daemon and qemu-keymap *are* tools; if they fail to build due to any dependencies, or due

Re: [PATCH] meson: Clean up some dependencies regarding qemu-system

2022-12-19 Thread Philippe Mathieu-Daudé
On 16/12/22 20:07, Helge Deller wrote: Reduce amount of compiled code and installed binaries if just the qemu utilities such as qemu-img, qemu-io and qemu-nbd have to be built. This helps to make those tools easier available on hosts where qemu-system or qemu-user isn't supported. Reason for th

Re: [PATCH] meson: Clean up some dependencies regarding qemu-system

2022-12-19 Thread Peter Maydell
On Mon, 19 Dec 2022 at 11:22, Helge Deller wrote: > > Hi Paolo, > > On 12/17/22 14:28, Paolo Bonzini wrote: > > These are wrong. qemu-bridge-helper, virtiofsd, qemu-storage-daemon > > and qemu-keymap *are* tools; if they fail to build due to any > > dependencies, or due to other compilation issue

Re: [PATCH] meson: Clean up some dependencies regarding qemu-system

2022-12-19 Thread Helge Deller
Hi Paolo, On 12/17/22 14:28, Paolo Bonzini wrote: On 12/16/22 20:07, Helge Deller wrote: @@ -3581,7 +3581,7 @@ subdir('qga')   # Don't build qemu-keymap if xkbcommon is not explicitly enabled   # when we don't build tools or system -if xkbcommon.found() +if xkbcommon.found() and have_system   

Re: [PATCH] meson: Clean up some dependencies regarding qemu-system

2022-12-17 Thread Paolo Bonzini
On 12/16/22 20:07, Helge Deller wrote: @@ -3581,7 +3581,7 @@ subdir('qga') # Don't build qemu-keymap if xkbcommon is not explicitly enabled # when we don't build tools or system -if xkbcommon.found() +if xkbcommon.found() and have_system # used for the update-keymaps target, so include r

[PATCH] meson: Clean up some dependencies regarding qemu-system

2022-12-16 Thread Helge Deller
Reduce amount of compiled code and installed binaries if just the qemu utilities such as qemu-img, qemu-io and qemu-nbd have to be built. This helps to make those tools easier available on hosts where qemu-system or qemu-user isn't supported. Reason for this patch is that qemu fail to build on de