Re: [PATCH] meson: move zlib detection to meson

2020-08-29 Thread Marc-André Lureau
On Fri, Aug 28, 2020 at 9:38 PM Paolo Bonzini wrote: > > Meson includes the same logic that tries to look for -lz if > pkg-config (and cmake) cannot find zlib. The undocumented > --disable-zlib-test option becomes a no-op. > > Signed-off-by: Paolo Bonzini Nice! (special treatment since 0.54), R

Re: [PATCH] meson: move zlib detection to meson

2020-08-28 Thread Paolo Bonzini
Il ven 28 ago 2020, 23:13 罗勇刚(Yonggang Luo) ha scritto: > - --disable-zlib-test) zlib="no" >> + --disable-zlib-test) >> > Why not remove this no-op > Because I did not want to introduce visible changes. Paolo

Re: [PATCH] meson: move zlib detection to meson

2020-08-28 Thread Yonggang Luo
On Sat, Aug 29, 2020 at 1:39 AM Paolo Bonzini wrote: > Meson includes the same logic that tries to look for -lz if > pkg-config (and cmake) cannot find zlib. The undocumented > --disable-zlib-test option becomes a no-op. > > Signed-off-by: Paolo Bonzini > --- > Makefile| 2 +- > configure

[PATCH] meson: move zlib detection to meson

2020-08-28 Thread Paolo Bonzini
Meson includes the same logic that tries to look for -lz if pkg-config (and cmake) cannot find zlib. The undocumented --disable-zlib-test option becomes a no-op. Signed-off-by: Paolo Bonzini --- Makefile| 2 +- configure | 32 +--- meson.build | 6 +- 3 f