Re: [PATCH] migration: Free argv

2024-02-25 Thread Akihiko Odaki
On 2024/02/26 12:49, Peter Xu wrote: On Sun, Feb 25, 2024 at 02:54:01PM +0900, Akihiko Odaki wrote: exec_start_outgoing_migration() and exec_start_incoming_migration() leak argv because it uses g_steal_pointer() is used to pass argv qio_channel_command_new_spawn() while it does not free argv

Re: [PATCH] migration: Free argv

2024-02-25 Thread Peter Xu
On Sun, Feb 25, 2024 at 02:54:01PM +0900, Akihiko Odaki wrote: > exec_start_outgoing_migration() and exec_start_incoming_migration() > leak argv because it uses g_steal_pointer() is used to pass argv > qio_channel_command_new_spawn() while it does not free argv either. > > Removing

[PATCH] migration: Free argv

2024-02-24 Thread Akihiko Odaki
exec_start_outgoing_migration() and exec_start_incoming_migration() leak argv because it uses g_steal_pointer() is used to pass argv qio_channel_command_new_spawn() while it does not free argv either. Removing g_steal_pointer() is not sufficient though because argv is typed g_auto(GStrv), which