Re: [PATCH] monitor/hmp-cmds: fix bad indentation in 'info migrate_parameters' cmd output

2020-03-21 Thread maozy
On 3/21/20 3:14 PM, Markus Armbruster wrote: "Dr. David Alan Gilbert" writes: * Daniel P. Berrangé (berra...@redhat.com) wrote: On Fri, Mar 20, 2020 at 05:31:17PM +, Dr. David Alan Gilbert wrote: (Rearranging the text a bit) * Markus Armbruster (arm...@redhat.com) wrote: David

Re: [PATCH] monitor/hmp-cmds: fix bad indentation in 'info migrate_parameters' cmd output

2020-03-21 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Daniel P. Berrangé (berra...@redhat.com) wrote: >> On Fri, Mar 20, 2020 at 05:31:17PM +, Dr. David Alan Gilbert wrote: >> > (Rearranging the text a bit) >> > >> > * Markus Armbruster (arm...@redhat.com) wrote: >> > >> > > David (cc'ed) should be able to

Re: [PATCH] monitor/hmp-cmds: fix bad indentation in 'info migrate_parameters' cmd output

2020-03-20 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Fri, Mar 20, 2020 at 05:31:17PM +, Dr. David Alan Gilbert wrote: > > (Rearranging the text a bit) > > > > * Markus Armbruster (arm...@redhat.com) wrote: > > > > > David (cc'ed) should be able to tell us which fix is right. > > > > > >

Re: [PATCH] monitor/hmp-cmds: fix bad indentation in 'info migrate_parameters' cmd output

2020-03-20 Thread Daniel P . Berrangé
On Fri, Mar 20, 2020 at 05:31:17PM +, Dr. David Alan Gilbert wrote: > (Rearranging the text a bit) > > * Markus Armbruster (arm...@redhat.com) wrote: > > > David (cc'ed) should be able to tell us which fix is right. > > > > @tls_creds and @tls_hostname look like they could have the same

Re: [PATCH] monitor/hmp-cmds: fix bad indentation in 'info migrate_parameters' cmd output

2020-03-20 Thread Dr. David Alan Gilbert
(Rearranging the text a bit) * Markus Armbruster (arm...@redhat.com) wrote: > David (cc'ed) should be able to tell us which fix is right. > > @tls_creds and @tls_hostname look like they could have the same issue. A certain Markus removed the Null checks in 8cc99dc because 4af245d guaranteed

Re: [PATCH] monitor/hmp-cmds: fix bad indentation in 'info migrate_parameters' cmd output

2020-03-20 Thread Markus Armbruster
Mao Zhongyi writes: > run: > (qemu) info migrate_parameters > announce-initial: 50 ms > ... > announce-max: 550 ms > multifd-compression: none > xbzrle-cache-size: 4194304 > max-postcopy-bandwidth: 0 > tls-authz: '(null)' > > The last line seems a bit out of place, fix it. Yes, indentation is

[PATCH] monitor/hmp-cmds: fix bad indentation in 'info migrate_parameters' cmd output

2020-03-20 Thread Mao Zhongyi
run: (qemu) info migrate_parameters announce-initial: 50 ms ... announce-max: 550 ms multifd-compression: none xbzrle-cache-size: 4194304 max-postcopy-bandwidth: 0 tls-authz: '(null)' The last line seems a bit out of place, fix it. Signed-off-by: Mao Zhongyi --- monitor/hmp-cmds.c | 2 +- 1