Re: [PATCH] monitor/qmp-cmds.c: Don't include ui/vnc.h

2021-01-15 Thread Markus Armbruster
Peter Maydell writes: > The qmp-cmds.c file currently includes ui/vnc.h, which (being located > in the ui/ directory rather than include) is really supposed to be > for use only by the ui subsystem. In fact the function prototypes we > need (vnc_display_password(), etc) are all declared in > inc

Re: [PATCH] monitor/qmp-cmds.c: Don't include ui/vnc.h

2021-01-04 Thread Peter Maydell
On Mon, 4 Jan 2021 at 16:30, Philippe Mathieu-Daudé wrote: > > On 1/4/21 5:12 PM, Peter Maydell wrote: > > The qmp-cmds.c file currently includes ui/vnc.h, which (being located > > in the ui/ directory rather than include) is really supposed to be > > for use only by the ui subsystem. > > That mak

Re: [PATCH] monitor/qmp-cmds.c: Don't include ui/vnc.h

2021-01-04 Thread Philippe Mathieu-Daudé
On 1/4/21 5:12 PM, Peter Maydell wrote: > The qmp-cmds.c file currently includes ui/vnc.h, which (being located > in the ui/ directory rather than include) is really supposed to be > for use only by the ui subsystem. That makes me remember yet another cleanup series I started few months ago to rem

[PATCH] monitor/qmp-cmds.c: Don't include ui/vnc.h

2021-01-04 Thread Peter Maydell
The qmp-cmds.c file currently includes ui/vnc.h, which (being located in the ui/ directory rather than include) is really supposed to be for use only by the ui subsystem. In fact the function prototypes we need (vnc_display_password(), etc) are all declared in include/ui/console.h, so we can switc