[PATCH] multifd: Set a higher "backlog" default value for listen()

When destination VM is launched, the "backlog" parameter for listen() is set to 1 as default in socket_start_incoming_migration_internal(), which will lead to socket connection error (the queue of pending connections is full) when "multifd" and "multifd-channels" are set later on and a high number

RE: [PATCH] multifd: Set a higher "backlog" default value for listen()

On Thursday, May 18, 2023 4:52 PM, Wang, Lei4 wrote: > When destination VM is launched, the "backlog" parameter for listen() is set > to 1 as default in socket_start_incoming_migration_internal(), which will > lead to socket connection error (the queue of pending connections is full) > when "multif

Re: [PATCH] multifd: Set a higher "backlog" default value for listen()

Lei Wang wrote: > When destination VM is launched, the "backlog" parameter for listen() is set > to 1 as default in socket_start_incoming_migration_internal(), which will > lead to socket connection error (the queue of pending connections is full) > when "multifd" and "multifd-channels" are set la

Re: [PATCH] multifd: Set a higher "backlog" default value for listen()

"Wang, Wei W" wrote: > On Thursday, May 18, 2023 4:52 PM, Wang, Lei4 wrote: >> When destination VM is launched, the "backlog" parameter for listen() is set >> to 1 as default in socket_start_incoming_migration_internal(), which will >> lead to socket connection error (the queue of pending connecti

Re: [PATCH] multifd: Set a higher "backlog" default value for listen()

On Thu, May 18, 2023 at 09:13:58AM +, Wang, Wei W wrote: > On Thursday, May 18, 2023 4:52 PM, Wang, Lei4 wrote: > > When destination VM is launched, the "backlog" parameter for listen() is set > > to 1 as default in socket_start_incoming_migration_internal(), which will > > lead to socket conne

Re: [PATCH] multifd: Set a higher "backlog" default value for listen()

Daniel P. Berrangé wrote: > On Thu, May 18, 2023 at 09:13:58AM +, Wang, Wei W wrote: >> On Thursday, May 18, 2023 4:52 PM, Wang, Lei4 wrote: >> > When destination VM is launched, the "backlog" parameter for listen() is >> > set >> > to 1 as default in socket_start_incoming_migration_internal(

RE: [PATCH] multifd: Set a higher "backlog" default value for listen()

On Thursday, May 18, 2023 8:43 PM, Juan Quintela wrote: > > > Are you using -incoming defer? > > No? right. > > With multifd, you should use -incoming defer. Yes, just confirmed that it works well with deferred incoming. I think we should enforce this kind of requirement in the code. I'll mak

Re: [PATCH] multifd: Set a higher "backlog" default value for listen()

"Wang, Wei W" wrote: > On Thursday, May 18, 2023 8:43 PM, Juan Quintela wrote: >> >> >> Are you using -incoming defer? >> >> No? right. >> >> With multifd, you should use -incoming defer. > > Yes, just confirmed that it works well with deferred incoming. > I think we should enforce this kind

Re: [PATCH] multifd: Set a higher "backlog" default value for listen()

On 5/18/2023 17:16, Juan Quintela wrote: > Lei Wang wrote: >> When destination VM is launched, the "backlog" parameter for listen() is set >> to 1 as default in socket_start_incoming_migration_internal(), which will >> lead to socket connection error (the queue of pending connections is full) >> w

RE: [PATCH] multifd: Set a higher "backlog" default value for listen()

On Friday, May 19, 2023 9:31 AM, Wang, Lei4 wrote: > On 5/18/2023 17:16, Juan Quintela wrote: > > Lei Wang wrote: > >> When destination VM is launched, the "backlog" parameter for listen() > >> is set to 1 as default in socket_start_incoming_migration_internal(), > >> which will lead to socket con

Re: [PATCH] multifd: Set a higher "backlog" default value for listen()

On 5/19/2023 10:44, Wang, Wei W wrote: > On Friday, May 19, 2023 9:31 AM, Wang, Lei4 wrote: >> On 5/18/2023 17:16, Juan Quintela wrote: >>> Lei Wang wrote: When destination VM is launched, the "backlog" parameter for listen() is set to 1 as default in socket_start_incoming_migration_inte

RE: [PATCH] multifd: Set a higher "backlog" default value for listen()

On Friday, May 19, 2023 10:52 AM, Wang, Lei4 wrote: > > We can change it to uint16_t or uint32_t, but need to see if listening > > on a larger value is OK to everyone. > > Is there any use case to use >256 migration channels? If not, then I suppose > it's no need to increase it. People can choose

Re: [PATCH] multifd: Set a higher "backlog" default value for listen()

"Wang, Wei W" wrote: > On Friday, May 19, 2023 9:31 AM, Wang, Lei4 wrote: >> On 5/18/2023 17:16, Juan Quintela wrote: >> > Lei Wang wrote: >> >> When destination VM is launched, the "backlog" parameter for listen() >> >> is set to 1 as default in socket_start_incoming_migration_internal(), >> >>

Re: [PATCH] multifd: Set a higher "backlog" default value for listen()

"Wang, Wei W" wrote: > On Friday, May 19, 2023 10:52 AM, Wang, Lei4 wrote: >> > We can change it to uint16_t or uint32_t, but need to see if listening >> > on a larger value is OK to everyone. >> >> Is there any use case to use >256 migration channels? If not, then I suppose >> it's no need to in

Re: [PATCH] multifd: Set a higher "backlog" default value for listen()

On Fri, May 19, 2023 at 01:22:20PM +0200, Juan Quintela wrote: > "Wang, Wei W" wrote: > > On Friday, May 19, 2023 9:31 AM, Wang, Lei4 wrote: > >> On 5/18/2023 17:16, Juan Quintela wrote: > >> > Lei Wang wrote: > >> >> When destination VM is launched, the "backlog" parameter for listen() > >> >> i