Re: [PATCH] nbd: Fix regression with multiple meta contexts

2020-02-12 Thread Laurent Vivier
Le 12/02/2020 à 13:10, Eric Blake a écrit : > On 2/12/20 3:24 AM, Laurent Vivier wrote: >> Le 06/02/2020 à 18:38, Eric Blake a écrit : >>> Detected by a hang in the libnbd testsuite.  If a client requests >>> multiple meta contexts (both base:allocation and qemu:dirty-bitmap:x) >>> at the same time

Re: [PATCH] nbd: Fix regression with multiple meta contexts

2020-02-12 Thread Eric Blake
On 2/12/20 3:24 AM, Laurent Vivier wrote: Le 06/02/2020 à 18:38, Eric Blake a écrit : Detected by a hang in the libnbd testsuite. If a client requests multiple meta contexts (both base:allocation and qemu:dirty-bitmap:x) at the same time, our attempt to silence a false-positive warning about a

Re: [PATCH] nbd: Fix regression with multiple meta contexts

2020-02-12 Thread Laurent Vivier
Le 06/02/2020 à 18:38, Eric Blake a écrit : > Detected by a hang in the libnbd testsuite. If a client requests > multiple meta contexts (both base:allocation and qemu:dirty-bitmap:x) > at the same time, our attempt to silence a false-positive warning > about a potential uninitialized variable intr

Re: [PATCH] nbd: Fix regression with multiple meta contexts

2020-02-06 Thread Laurent Vivier
Le 06/02/2020 à 18:38, Eric Blake a écrit : > Detected by a hang in the libnbd testsuite. If a client requests > multiple meta contexts (both base:allocation and qemu:dirty-bitmap:x) > at the same time, our attempt to silence a false-positive warning > about a potential uninitialized variable intr

[PATCH] nbd: Fix regression with multiple meta contexts

2020-02-06 Thread Eric Blake
Detected by a hang in the libnbd testsuite. If a client requests multiple meta contexts (both base:allocation and qemu:dirty-bitmap:x) at the same time, our attempt to silence a false-positive warning about a potential uninitialized variable introduced botched logic: we were short-circuiting the s