Re: [PATCH] net/vmnet: Pad short Ethernet frames

2024-01-09 Thread William Hooper
On Mon, Jan 8, 2024 at 7:36 AM Philippe Mathieu-Daudé wrote: > Don't we want to initialize min_pktsz here ... > >min_pktsz = sizeof(min_pkt); > > > +if (eth_pad_short_frame(min_pkt, &min_pktsz, pkt, pktsz)) { > > ... because eth_pad_short_frame() update it? Thanks for

Re: [PATCH] net/vmnet: Pad short Ethernet frames

2024-01-08 Thread Philippe Mathieu-Daudé
Hi William, On 6/1/24 23:35, William Hooper wrote: At least on macOS 12.7.2, vmnet doesn't pad Ethernet frames, such as the host's ARP replies, to the minimum size (60 bytes before the frame check sequence) defined in IEEE Std 802.3-2022, so guests' Ethernet device drivers may drop them with "fr

Re: [PATCH] net/vmnet: Pad short Ethernet frames

2024-01-07 Thread Bin Meng
On Sun, Jan 7, 2024 at 7:19 AM William Hooper wrote: > > At least on macOS 12.7.2, vmnet doesn't pad Ethernet frames, such as the > host's ARP replies, to the minimum size (60 bytes before the frame check > sequence) defined in IEEE Std 802.3-2022, so guests' Ethernet device > drivers may drop the

[PATCH] net/vmnet: Pad short Ethernet frames

2024-01-06 Thread William Hooper
At least on macOS 12.7.2, vmnet doesn't pad Ethernet frames, such as the host's ARP replies, to the minimum size (60 bytes before the frame check sequence) defined in IEEE Std 802.3-2022, so guests' Ethernet device drivers may drop them with "frame too short" errors. This patch calls eth_pad_short