On 210219 1243, Li Qiang wrote:
> Alexander Bulekov 于2021年2月19日周五 上午10:15写道：
> >
> > On 210219 1006, Li Qiang wrote:
> > > Alexander Bulekov 于2021年2月19日周五 上午9:56写道：
> > > >
> > > > On 210218 1441, Peter Maydell wrote:
> > > > > On Thu, 18 Feb 2021 at 14:13, P J P wrote:
> > > > > >
> > > > > > F
Am 19.02.21 um 10:26 schrieb P J P:
Hello Stefan,
+-- On Fri, 19 Feb 2021, Stefan Weil wrote --+
| If there are no recursions in normal use, the following patch should work:
|
| diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c
| index 16e95ef9cc..2474cf3dc2 100644
| --- a/hw/net/eepro100.c
Hello Stefan,
+-- On Fri, 19 Feb 2021, Stefan Weil wrote --+
| If there are no recursions in normal use, the following patch should work:
|
| diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c
| index 16e95ef9cc..2474cf3dc2 100644
| --- a/hw/net/eepro100.c
| +++ b/hw/net/eepro100.c
| @@ -279,6
Am 19.02.21 um 09:08 schrieb Stefan Weil:
Okay, I can confirm the infinite recursion now.
The test case triggers memory writes by the hardware which cause new
actions of the same hardware and so on.
I don't know how the real hardware would handle that case.
For QEMU we can extend the curren
Am 19.02.21 um 07:11 schrieb P J P:
Hello Alex, Stefan, all
+-- On Thu, 18 Feb 2021, Alexander Bulekov wrote --+
| Maybe the infinite loop mentioned in the commit message is actually a DMA
| recursion issue? I'm providing a reproducer for a DMA re-entracy issue
| below. With this patch appli
Hello Alex, Stefan, all
+-- On Thu, 18 Feb 2021, Alexander Bulekov wrote --+
| Maybe the infinite loop mentioned in the commit message is actually a DMA
| recursion issue? I'm providing a reproducer for a DMA re-entracy issue
| below. With this patch applied, the reproducer triggers the assert
Alexander Bulekov 于2021年2月19日周五 上午10:15写道：
>
> On 210219 1006, Li Qiang wrote:
> > Alexander Bulekov 于2021年2月19日周五 上午9:56写道：
> > >
> > > On 210218 1441, Peter Maydell wrote:
> > > > On Thu, 18 Feb 2021 at 14:13, P J P wrote:
> > > > >
> > > > > From: Prasad J Pandit
> > > > >
> > > > > While pr
On 210219 1006, Li Qiang wrote:
> Alexander Bulekov 于2021年2月19日周五 上午9:56写道：
> >
> > On 210218 1441, Peter Maydell wrote:
> > > On Thu, 18 Feb 2021 at 14:13, P J P wrote:
> > > >
> > > > From: Prasad J Pandit
> > > >
> > > > While processing controller commands, eepro100 emulator gets
> > > > com
Alexander Bulekov 于2021年2月19日周五 上午9:56写道：
>
> On 210218 1441, Peter Maydell wrote:
> > On Thu, 18 Feb 2021 at 14:13, P J P wrote:
> > >
> > > From: Prasad J Pandit
> > >
> > > While processing controller commands, eepro100 emulator gets
> > > command unit(CU) base address OR receive unit (RU) ba
On 210218 1441, Peter Maydell wrote:
> On Thu, 18 Feb 2021 at 14:13, P J P wrote:
> >
> > From: Prasad J Pandit
> >
> > While processing controller commands, eepro100 emulator gets
> > command unit(CU) base address OR receive unit (RU) base address
> > OR command block (CB) address from guest. If
Am 18.02.21 um 15:41 schrieb Peter Maydell:
On Thu, 18 Feb 2021 at 14:13, P J P wrote:
From: Prasad J Pandit
While processing controller commands, eepro100 emulator gets
command unit(CU) base address OR receive unit (RU) base address
OR command block (CB) address from guest. If these values
On Thu, 18 Feb 2021 at 14:13, P J P wrote:
>
> From: Prasad J Pandit
>
> While processing controller commands, eepro100 emulator gets
> command unit(CU) base address OR receive unit (RU) base address
> OR command block (CB) address from guest. If these values are not
> checked, it may lead to an
Patchew URL:
https://patchew.org/QEMU/20210218140629.373646-1-ppan...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210218140629.373646-1-ppan...@redhat.com
Subject: [PATCH] net: eepro100: validate
From: Prasad J Pandit
While processing controller commands, eepro100 emulator gets
command unit(CU) base address OR receive unit (RU) base address
OR command block (CB) address from guest. If these values are not
checked, it may lead to an infinite loop kind of issues. Add checks
to avoid it.
Re
14 matches
Mail list logo
