Re: [PATCH] ppc/pnv: Add an I2C master controller model

2023-10-10 Thread Miles Glenn
On Mon, 2023-10-09 at 22:42 +0200, Cédric Le Goater wrote: > Hello Glenn, > > On 10/9/23 20:05, Glenn Miles wrote: > > From: Cédric Le Goater > > > > Not supported : > > > > . 10 bit addresses > > . multimaster > > . slave > > > > Signed-off-by: Cédric Le Goater > > Signed-off-by:

Re: [PATCH] ppc/pnv: Add an I2C master controller model

2023-10-09 Thread Cédric Le Goater
Hello Glenn, On 10/9/23 20:05, Glenn Miles wrote: From: Cédric Le Goater Not supported : . 10 bit addresses . multimaster . slave Signed-off-by: Cédric Le Goater Signed-off-by: Glenn Miles [milesg: fixed formatting warning] Overall it looks good ;) Some suggestions for the

[PATCH] ppc/pnv: Add an I2C master controller model

2023-10-09 Thread Glenn Miles
From: Cédric Le Goater Not supported : . 10 bit addresses . multimaster . slave Signed-off-by: Cédric Le Goater Signed-off-by: Glenn Miles [milesg: fixed formatting warning] --- hw/ppc/meson.build | 1 + hw/ppc/pnv.c | 26 ++ hw/ppc/pnv_i2c.c | 678