Re: [PATCH] ppc/ppc405_boards: Remove unnecessary NULL check

2020-03-22 Thread David Gibson
On Sun, Mar 22, 2020 at 10:06:13AM +, Peter Maydell wrote: > On Sun, 22 Mar 2020 at 08:50, David Gibson > wrote: > > > > On Fri, Mar 20, 2020 at 04:57:40PM +0100, Philippe Mathieu-Daudé wrote: > > > This code is inside the "if (dinfo)" condition, so testing > > > again here whether it is NULL

Re: [PATCH] ppc/ppc405_boards: Remove unnecessary NULL check

2020-03-22 Thread Peter Maydell
On Sun, 22 Mar 2020 at 08:50, David Gibson wrote: > > On Fri, Mar 20, 2020 at 04:57:40PM +0100, Philippe Mathieu-Daudé wrote: > > This code is inside the "if (dinfo)" condition, so testing > > again here whether it is NULL is unnecessary. > > > > Fixes: dd59bcae7 (Don't size flash memory to match

Re: [PATCH] ppc/ppc405_boards: Remove unnecessary NULL check

2020-03-22 Thread David Gibson
On Fri, Mar 20, 2020 at 04:57:40PM +0100, Philippe Mathieu-Daudé wrote: > This code is inside the "if (dinfo)" condition, so testing > again here whether it is NULL is unnecessary. > > Fixes: dd59bcae7 (Don't size flash memory to match backing image) > Reported-by: Coverity (CID 1421917) > Suggest

Re: [PATCH] ppc/ppc405_boards: Remove unnecessary NULL check

2020-03-20 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > This code is inside the "if (dinfo)" condition, so testing > again here whether it is NULL is unnecessary. > > Fixes: dd59bcae7 (Don't size flash memory to match backing image) > Reported-by: Coverity (CID 1421917) > Suggested-by: Peter Maydell > Signed-off-by: P

[PATCH] ppc/ppc405_boards: Remove unnecessary NULL check

2020-03-20 Thread Philippe Mathieu-Daudé
This code is inside the "if (dinfo)" condition, so testing again here whether it is NULL is unnecessary. Fixes: dd59bcae7 (Don't size flash memory to match backing image) Reported-by: Coverity (CID 1421917) Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/ppc405_boar