Re: [PATCH] ppc: qtest already exports qtest_rtas_call()

2023-11-07 Thread Daniel Henrique Barboza
Queue in ppc-next after amending this in: $ git diff diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c index cec01b2c92..f329693c55 100644 --- a/hw/ppc/spapr_rtas.c +++ b/hw/ppc/spapr_rtas.c @@ -38,7 +38,6 @@ #include "hw/ppc/spapr.h" #include "hw/ppc/spapr_vio.h" -#include "hw/ppc/spa

Re: [PATCH] ppc: qtest already exports qtest_rtas_call()

2023-10-31 Thread Cédric Le Goater
On 10/31/23 11:15, Juan Quintela wrote: David Gibson wrote: On Mon, Oct 30, 2023 at 05:41:36PM +0100, Cédric le Goater wrote: On 10/30/23 17:38, Juan Quintela wrote: Having two functions with the same name is a bad idea. As spapr only uses the function locally, made it static. When you comp

Re: [PATCH] ppc: qtest already exports qtest_rtas_call()

2023-10-31 Thread Juan Quintela
David Gibson wrote: > On Mon, Oct 30, 2023 at 05:41:36PM +0100, Cédric le Goater wrote: >> On 10/30/23 17:38, Juan Quintela wrote: >> > Having two functions with the same name is a bad idea. As spapr only >> > uses the function locally, made it static. >> > >> > When you compile with clang, you

Re: [PATCH] ppc: qtest already exports qtest_rtas_call()

2023-10-30 Thread David Gibson
On Mon, Oct 30, 2023 at 05:41:36PM +0100, Cédric le Goater wrote: > On 10/30/23 17:38, Juan Quintela wrote: > > Having two functions with the same name is a bad idea. As spapr only > > uses the function locally, made it static. > > > > When you compile with clang, you get this compilation error:

Re: [PATCH] ppc: qtest already exports qtest_rtas_call()

2023-10-30 Thread Cédric Le Goater
On 10/30/23 17:38, Juan Quintela wrote: Having two functions with the same name is a bad idea. As spapr only uses the function locally, made it static. When you compile with clang, you get this compilation error: /usr/bin/ld: tests/qtest/libqos/libqos.fa.p/.._libqtest.c.o: in function `qtest_

[PATCH] ppc: qtest already exports qtest_rtas_call()

2023-10-30 Thread Juan Quintela
Having two functions with the same name is a bad idea. As spapr only uses the function locally, made it static. When you compile with clang, you get this compilation error: /usr/bin/ld: tests/qtest/libqos/libqos.fa.p/.._libqtest.c.o: in function `qtest_rtas_call': /scratch/qemu/clang/full/all/.