Re: [PATCH] qapi: better document NVMe blockdev @device parameter

2019-12-10 Thread Kevin Wolf
Am 06.12.2019 um 15:38 hat Daniel P. Berrangé geschrieben: > Mention that this is a PCI device address & give the format it is > expected it. Also mention that it must be first unbound from any > host kernel driver. > > Signed-off-by: Daniel P. Berrangé Thanks, applied to the block branch. Kevi

Re: [PATCH] qapi: better document NVMe blockdev @device parameter

2019-12-06 Thread Daniel P . Berrangé
On Fri, Dec 06, 2019 at 08:51:15AM -0600, Eric Blake wrote: > On 12/6/19 8:38 AM, Daniel P. Berrangé wrote: > > Mention that this is a PCI device address & give the format it is > > expected it. Also mention that it must be first unbound from any > > maybe s/expected it/expecting/ It was supposed

Re: [PATCH] qapi: better document NVMe blockdev @device parameter

2019-12-06 Thread Eric Blake
On 12/6/19 8:38 AM, Daniel P. Berrangé wrote: Mention that this is a PCI device address & give the format it is expected it. Also mention that it must be first unbound from any maybe s/expected it/expecting/ host kernel driver. Signed-off-by: Daniel P. Berrangé --- qapi/block-core.json |

Re: [PATCH] qapi: better document NVMe blockdev @device parameter

2019-12-06 Thread Stefan Hajnoczi
On Fri, Dec 06, 2019 at 02:38:11PM +, Daniel P. Berrangé wrote: > Mention that this is a PCI device address & give the format it is > expected it. Also mention that it must be first unbound from any > host kernel driver. > > Signed-off-by: Daniel P. Berrangé > --- > qapi/block-core.json | 6

[PATCH] qapi: better document NVMe blockdev @device parameter

2019-12-06 Thread Daniel P . Berrangé
Mention that this is a PCI device address & give the format it is expected it. Also mention that it must be first unbound from any host kernel driver. Signed-off-by: Daniel P. Berrangé --- qapi/block-core.json | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qapi/block-co