Re: [PATCH] qmp: Reset mon->commands on CHR_EVENT_CLOSED

2019-11-13 Thread Jason Andryuk
On Wed, Nov 13, 2019 at 8:18 AM Marc-André Lureau wrote: > > Hi > > On Wed, Nov 13, 2019 at 4:41 PM Markus Armbruster wrote: > > > > Jason Andryuk writes: > > > > > Currently, mon->commands is uninitialized until CHR_EVENT_OPENED where > > > it is set to _cap_negotiation_commands. After

Re: [PATCH] qmp: Reset mon->commands on CHR_EVENT_CLOSED

2019-11-13 Thread Marc-André Lureau
Hi On Wed, Nov 13, 2019 at 4:41 PM Markus Armbruster wrote: > > Jason Andryuk writes: > > > Currently, mon->commands is uninitialized until CHR_EVENT_OPENED where > > it is set to _cap_negotiation_commands. After capability > > negotiation, it is set to _commands. If the chardev is closed, >

Re: [PATCH] qmp: Reset mon->commands on CHR_EVENT_CLOSED

2019-11-13 Thread Markus Armbruster
Jason Andryuk writes: > Currently, mon->commands is uninitialized until CHR_EVENT_OPENED where > it is set to _cap_negotiation_commands. After capability > negotiation, it is set to _commands. If the chardev is closed, > CHR_EVENT_CLOSED, mon->commands remains as _commands. Only once the >

Re: [PATCH] qmp: Reset mon->commands on CHR_EVENT_CLOSED

2019-11-07 Thread Jason Andryuk
On Wed, Nov 6, 2019 at 8:08 PM wrote: > > Patchew URL: > https://patchew.org/QEMU/20191106130309.6737-1-jandr...@gmail.com/ > > > > Hi, > > This series failed the docker-quick@centos7 build test. Please find the > testing commands and > their output below. If you have Docker installed, you can

Re: [PATCH] qmp: Reset mon->commands on CHR_EVENT_CLOSED

2019-11-06 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191106130309.6737-1-jandr...@gmail.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH] qmp: Reset mon->commands on CHR_EVENT_CLOSED

2019-11-06 Thread Jason Andryuk
On Wed, Nov 6, 2019 at 9:53 AM Marc-André Lureau wrote: > > Hi > > On Wed, Nov 6, 2019 at 5:04 PM Jason Andryuk wrote: > > > > Currently, mon->commands is uninitialized until CHR_EVENT_OPENED where > > it is set to _cap_negotiation_commands. After capability > > negotiation, it is set to

Re: [PATCH] qmp: Reset mon->commands on CHR_EVENT_CLOSED

2019-11-06 Thread Marc-André Lureau
Hi On Wed, Nov 6, 2019 at 5:04 PM Jason Andryuk wrote: > > Currently, mon->commands is uninitialized until CHR_EVENT_OPENED where > it is set to _cap_negotiation_commands. After capability > negotiation, it is set to _commands. If the chardev is closed, > CHR_EVENT_CLOSED, mon->commands

[PATCH] qmp: Reset mon->commands on CHR_EVENT_CLOSED

2019-11-06 Thread Jason Andryuk
Currently, mon->commands is uninitialized until CHR_EVENT_OPENED where it is set to _cap_negotiation_commands. After capability negotiation, it is set to _commands. If the chardev is closed, CHR_EVENT_CLOSED, mon->commands remains as _commands. Only once the chardev is re-opened with