Re: [PATCH] softfloat: Handle m68k extended precision denormals properly

2023-08-21 Thread BALATON Zoltan
On Sun, 20 Aug 2023, Richard Henderson wrote: Motorola treats denormals with explicit integer bit set as having unbiased exponent 0, unlike Intel which treats it as having unbiased exponent 1 (like all other IEEE formats). Add a flag on FloatFmt to differentiate the behaviour. Reported-by:

Re: [PATCH] softfloat: Handle m68k extended precision denormals properly

2023-08-21 Thread Philippe Mathieu-Daudé
On 21/8/23 02:32, Richard Henderson wrote: Motorola treats denormals with explicit integer bit set as having unbiased exponent 0, unlike Intel which treats it as having unbiased exponent 1 (like all other IEEE formats). Add a flag on FloatFmt to differentiate the behaviour. Reported-by: Keith

Re: [PATCH] softfloat: Handle m68k extended precision denormals properly

2023-08-20 Thread Keith Packard via
> That does look like a correct change. I'll fold it in. > Please let us know if you encounter anything else. Thanks so much. With these fixes, all of my long double math library tests in picolibc are passing now (once I fixed a bunch of additional m68k-denorm related math library bugs). That

Re: [PATCH] softfloat: Handle m68k extended precision denormals properly

2023-08-20 Thread Richard Henderson
On 8/20/23 18:24, Keith Packard wrote: Motorola treats denormals with explicit integer bit set as having unbiased exponent 0, unlike Intel which treats it as having unbiased exponent 1 (like all other IEEE formats). Thanks for having a look at this. Your patch fixes a couple of cases, but

Re: [PATCH] softfloat: Handle m68k extended precision denormals properly

2023-08-20 Thread Keith Packard via
> Motorola treats denormals with explicit integer bit set as > having unbiased exponent 0, unlike Intel which treats it as > having unbiased exponent 1 (like all other IEEE formats). Thanks for having a look at this. Your patch fixes a couple of cases, but there are further adventures that await

[PATCH] softfloat: Handle m68k extended precision denormals properly

2023-08-20 Thread Richard Henderson
Motorola treats denormals with explicit integer bit set as having unbiased exponent 0, unlike Intel which treats it as having unbiased exponent 1 (like all other IEEE formats). Add a flag on FloatFmt to differentiate the behaviour. Reported-by: Keith Packard Signed-off-by: Richard Henderson