Re: [PATCH] spapr: Don't request to unplug the same core twice

2019-10-29 Thread David Gibson
On Thu, Oct 24, 2019 at 08:28:54AM +0200, Greg Kurz wrote: > On Thu, 24 Oct 2019 09:38:17 +1100 > David Gibson wrote: > > > On Wed, Oct 23, 2019 at 09:17:40PM +0200, Greg Kurz wrote: > > > We must not call spapr_drc_detach() on a detached DRC otherwise bad things > > > can happen, ie. QEMU hangs

Re: [PATCH] spapr: Don't request to unplug the same core twice

2019-10-24 Thread Greg Kurz
On Thu, 24 Oct 2019 09:38:17 +1100 David Gibson wrote: > On Wed, Oct 23, 2019 at 09:17:40PM +0200, Greg Kurz wrote: > > We must not call spapr_drc_detach() on a detached DRC otherwise bad things > > can happen, ie. QEMU hangs or crashes. This is easily demonstrated with > > a CPU hotplug/unplug

Re: [PATCH] spapr: Don't request to unplug the same core twice

2019-10-23 Thread David Gibson
On Wed, Oct 23, 2019 at 09:17:40PM +0200, Greg Kurz wrote: > We must not call spapr_drc_detach() on a detached DRC otherwise bad things > can happen, ie. QEMU hangs or crashes. This is easily demonstrated with > a CPU hotplug/unplug loop using QMP. > > Signed-off-by: Greg Kurz Ouch, good catch.

[PATCH] spapr: Don't request to unplug the same core twice

2019-10-23 Thread Greg Kurz
We must not call spapr_drc_detach() on a detached DRC otherwise bad things can happen, ie. QEMU hangs or crashes. This is easily demonstrated with a CPU hotplug/unplug loop using QMP. Signed-off-by: Greg Kurz --- hw/ppc/spapr.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-)