Re: [PATCH] target/arm: Correct calculation of tlb range invalidate length

2021-12-01 Thread Philippe Mathieu-Daudé
On 11/30/21 18:32, Peter Maydell wrote: > The calculation of the length of TLB range invalidate operations > in tlbi_aa64_range_get_length() is incorrect in two ways: > * the NUM field is 5 bits, but we read only 4 bits > * we miscalculate the page_shift value, because of an >off-by-one error

Re: [PATCH] target/arm: Correct calculation of tlb range invalidate length

2021-11-30 Thread Alex Bennée
Peter Maydell writes: > The calculation of the length of TLB range invalidate operations > in tlbi_aa64_range_get_length() is incorrect in two ways: > * the NUM field is 5 bits, but we read only 4 bits > * we miscalculate the page_shift value, because of an >off-by-one error: > TG 0b0

Re: [PATCH] target/arm: Correct calculation of tlb range invalidate length

2021-11-30 Thread Richard Henderson
On 11/30/21 6:32 PM, Peter Maydell wrote: The calculation of the length of TLB range invalidate operations in tlbi_aa64_range_get_length() is incorrect in two ways: * the NUM field is 5 bits, but we read only 4 bits * we miscalculate the page_shift value, because of an off-by-one error:

[PATCH] target/arm: Correct calculation of tlb range invalidate length

2021-11-30 Thread Peter Maydell
The calculation of the length of TLB range invalidate operations in tlbi_aa64_range_get_length() is incorrect in two ways: * the NUM field is 5 bits, but we read only 4 bits * we miscalculate the page_shift value, because of an off-by-one error: TG 0b00 is invalid TG 0b01 is 4K granule