On Thu, 3 Aug 2023 at 15:42, Richard Henderson
wrote:
>
> On 8/3/23 06:10, Peter Maydell wrote:
> > On Thu, 27 Jul 2023 at 17:33, Richard Henderson
> >> -mop = MO_128;
> >> -if (s->align_mem) {
> >> -mop |= MO_ALIGN_8;
> >> -}
> >> -mop = finalize_memop_pair(s, mop);
> >>
On 8/3/23 06:10, Peter Maydell wrote:
On Thu, 27 Jul 2023 at 17:33, Richard Henderson
-mop = MO_128;
-if (s->align_mem) {
-mop |= MO_ALIGN_8;
-}
-mop = finalize_memop_pair(s, mop);
+mop = MO_128 | MO_ALIGN | MO_ATOM_IFALIGN_PAIR;
So here we're implicitly assuming
On Thu, 27 Jul 2023 at 17:33, Richard Henderson
wrote:
>
> STGP writes to tag memory, it does not check it.
> This happened to work because we wrote tag memory first
> so that the check always succeeded.
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/tcg/translate-a64.c | 41
On 7/28/23 06:17, Peter Maydell wrote:
On Thu, 27 Jul 2023 at 17:33, Richard Henderson
wrote:
STGP writes to tag memory, it does not check it.
This happened to work because we wrote tag memory first
so that the check always succeeded.
So this is code cleanup to be more sensible, rather
than
On Thu, 27 Jul 2023 at 17:33, Richard Henderson
wrote:
>
> STGP writes to tag memory, it does not check it.
> This happened to work because we wrote tag memory first
> so that the check always succeeded.
So this is code cleanup to be more sensible, rather
than a guest visible bug ?
thanks
--
STGP writes to tag memory, it does not check it.
This happened to work because we wrote tag memory first
so that the check always succeeded.
Signed-off-by: Richard Henderson
---
target/arm/tcg/translate-a64.c | 41 +-
1 file changed, 15 insertions(+), 26
