Re: [PATCH] target/arm: Fix AddPAC error indication

2020-07-30 Thread Peter Maydell
On Tue, 28 Jul 2020 at 20:57, Richard Henderson wrote: > > The definition of top_bit used in this function is one higher > than that used in the Arm ARM psuedo-code, which put the error > indication at top_bit - 1 at the wrong place, which meant that > it wasn't visible to Auth. > > Fixing the def

[PATCH] target/arm: Fix AddPAC error indication

2020-07-28 Thread Richard Henderson
The definition of top_bit used in this function is one higher than that used in the Arm ARM psuedo-code, which put the error indication at top_bit - 1 at the wrong place, which meant that it wasn't visible to Auth. Fixing the definition of top_bit requires more changes, because its most common use