Re: [PATCH] target/arm: Fix qemu-system-arm handling of LPAE block descriptors for highmem

2022-06-27 Thread Richard Henderson
On 6/27/22 19:16, Peter Maydell wrote: In commit 39a1fd25287f5d we fixed a bug in the handling of LPAE block descriptors where we weren't correctly zeroing out some RES0 bits. However this fix has a bug because the calculation of the mask is done at the wrong width: in descaddr &= ~(page_size

Re: [PATCH] target/arm: Fix qemu-system-arm handling of LPAE block descriptors for highmem

2022-06-27 Thread Peter Maydell
...forgot to actually cc qemu-stable. (I'm still not sure if that's important to the stable-branch process...) -- PMM On Mon, 27 Jun 2022 at 14:46, Peter Maydell wrote: > > In commit 39a1fd25287f5d we fixed a bug in the handling of LPAE block > descriptors where we weren't correctly zeroing out

[PATCH] target/arm: Fix qemu-system-arm handling of LPAE block descriptors for highmem

2022-06-27 Thread Peter Maydell
In commit 39a1fd25287f5d we fixed a bug in the handling of LPAE block descriptors where we weren't correctly zeroing out some RES0 bits. However this fix has a bug because the calculation of the mask is done at the wrong width: in descaddr &= ~(page_size - 1); page_size is a target_ulong, so in t