Patchew URL:
https://patchew.org/QEMU/20200423110915.10527-1-peter.mayd...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH] target/arm: Use correct variable for setting 'max' cpu's
ID_AA64
On Thu, Apr 23, 2020 at 1:09 PM Peter Maydell wrote:
>
> In aarch64_max_initfn() we update both 32-bit and 64-bit ID
> registers. The intended pattern is that for 64-bit ID registers we
> use FIELD_DP64 and the uint64_t 't' register, while 32-bit ID
> registers use FIELD_DP32 and the uint32_t 'u'
On Thu, Apr 23, 2020 at 1:09 PM Peter Maydell wrote:
>
> In aarch64_max_initfn() we update both 32-bit and 64-bit ID
> registers. The intended pattern is that for 64-bit ID registers we
> use FIELD_DP64 and the uint64_t 't' register, while 32-bit ID
> registers use FIELD_DP32 and the uint32_t 'u'
In aarch64_max_initfn() we update both 32-bit and 64-bit ID
registers. The intended pattern is that for 64-bit ID registers we
use FIELD_DP64 and the uint64_t 't' register, while 32-bit ID
registers use FIELD_DP32 and the uint32_t 'u' register. For
ID_AA64DFR0 we accidentally used 'u', meaning th