Re: [PATCH] target/i386: add -cpu,lbr=true support to enable guest LBR

2020-09-29 Thread Xu, Like
Hi Eduardo, On 2020/9/28 23:41, Eduardo Habkost wrote: On Mon, Sep 28, 2020 at 10:51:03PM +0800, Xu, Like wrote: Hi Eduardo, Thanks for your detailed review. On 2020/9/25 6:05, Eduardo Habkost wrote: I've just noticed this on my review queue (apologies for the long delay). Comments below:

Re: [PATCH] target/i386: add -cpu,lbr=true support to enable guest LBR

2020-09-28 Thread Eduardo Habkost
On Mon, Sep 28, 2020 at 10:51:03PM +0800, Xu, Like wrote: > Hi Eduardo, > > Thanks for your detailed review. > > On 2020/9/25 6:05, Eduardo Habkost wrote: > > I've just noticed this on my review queue (apologies for the long > > delay). Comments below: > > > > On Sun, Jul 26, 2020 at

Re: [PATCH] target/i386: add -cpu,lbr=true support to enable guest LBR

2020-09-28 Thread Xu, Like
Hi Eduardo, Thanks for your detailed review. On 2020/9/25 6:05, Eduardo Habkost wrote: I've just noticed this on my review queue (apologies for the long delay). Comments below: On Sun, Jul 26, 2020 at 11:32:20PM +0800, Like Xu wrote: The LBR feature would be enabled on the guest if: - the

Re: [PATCH] target/i386: add -cpu,lbr=true support to enable guest LBR

2020-09-24 Thread Eduardo Habkost
I've just noticed this on my review queue (apologies for the long delay). Comments below: On Sun, Jul 26, 2020 at 11:32:20PM +0800, Like Xu wrote: > The LBR feature would be enabled on the guest if: > - the KVM is enabled and the PMU is enabled and, > - the msr-based-feature

[PATCH] target/i386: add -cpu,lbr=true support to enable guest LBR

2020-07-26 Thread Like Xu
The LBR feature would be enabled on the guest if: - the KVM is enabled and the PMU is enabled and, - the msr-based-feature IA32_PERF_CAPABILITIES is supporterd and, - the supported returned value for lbr_fmt from this msr is not zero. The LBR feature would be disabled on the guest if: - the