Re: [PATCH] target/i386: clean up AAM/AAD

2024-05-22 Thread Richard Henderson
On 5/22/24 05:39, Paolo Bonzini wrote: The 32-bit AAM/AAD opcodes are using helpers that read and write flags and env->regs[R_EAX]. Clean them up so that the table correctly includes AX as a 16-bit input and output. No real reason to do it to be honest, but they are nice one-output helpers and

[PATCH] target/i386: clean up AAM/AAD

2024-05-22 Thread Paolo Bonzini
The 32-bit AAM/AAD opcodes are using helpers that read and write flags and env->regs[R_EAX]. Clean them up so that the table correctly includes AX as a 16-bit input and output. No real reason to do it to be honest, but they are nice one-output helpers and it removes the masking of