Re: [PATCH] target/ppc: fix unreachable code in fpu_helper.c

2022-06-06 Thread Daniel Henrique Barboza
Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks, Daniel On 6/2/22 16:10, Daniel Henrique Barboza wrote: Commit c29018cc7395 added an env->fpscr OR operation using a ternary that checks if 'error' is not zero: env->fpscr |= error ? FP_FEX : 0; However, in the current body of do_

Re: [PATCH] target/ppc: fix unreachable code in fpu_helper.c

2022-06-02 Thread Lucas Mateus Martins Araujo e Castro
On 02/06/2022 16:10, Daniel Henrique Barboza wrote: Commit c29018cc7395 added an env->fpscr OR operation using a ternary that checks if 'error' is not zero: env->fpscr |= error ? FP_FEX : 0; However, in the current body of do_fpscr_check_status(), 'error' is granted to be always non-zero

[PATCH] target/ppc: fix unreachable code in fpu_helper.c

2022-06-02 Thread Daniel Henrique Barboza
Commit c29018cc7395 added an env->fpscr OR operation using a ternary that checks if 'error' is not zero: env->fpscr |= error ? FP_FEX : 0; However, in the current body of do_fpscr_check_status(), 'error' is granted to be always non-zero at that point. The result is that Coverity is less than