Re: [PATCH] target/riscv: Remove unuseful KVM stubs

2023-07-02 Thread Alistair Francis
On Tue, Jun 20, 2023 at 6:17 PM Philippe Mathieu-Daudé wrote: > > Since we always check whether KVM is enabled before calling > kvm_riscv_reset_vcpu() and kvm_riscv_set_irq(), their call > is elided by the compiler when KVM is not available. > Therefore the stubs are not even linked. Remove them.

Re: [PATCH] target/riscv: Remove unuseful KVM stubs

2023-07-02 Thread Alistair Francis
On Tue, Jun 20, 2023 at 6:17 PM Philippe Mathieu-Daudé wrote: > > Since we always check whether KVM is enabled before calling > kvm_riscv_reset_vcpu() and kvm_riscv_set_irq(), their call > is elided by the compiler when KVM is not available. > Therefore the stubs are not even linked. Remove them.

Re: [PATCH] target/riscv: Remove unuseful KVM stubs

2023-06-30 Thread Daniel Henrique Barboza
On 6/20/23 05:16, Philippe Mathieu-Daudé wrote: Since we always check whether KVM is enabled before calling kvm_riscv_reset_vcpu() and kvm_riscv_set_irq(), their call is elided by the compiler when KVM is not available. Had to google 'elided'. Nice touch. Therefore the stubs are not even l

Re: [PATCH] target/riscv: Remove unuseful KVM stubs

2023-06-29 Thread Philippe Mathieu-Daudé
ping? On 20/6/23 10:16, Philippe Mathieu-Daudé wrote: Since we always check whether KVM is enabled before calling kvm_riscv_reset_vcpu() and kvm_riscv_set_irq(), their call is elided by the compiler when KVM is not available. Therefore the stubs are not even linked. Remove them. Signed-off-by:

[PATCH] target/riscv: Remove unuseful KVM stubs

2023-06-20 Thread Philippe Mathieu-Daudé
Since we always check whether KVM is enabled before calling kvm_riscv_reset_vcpu() and kvm_riscv_set_irq(), their call is elided by the compiler when KVM is not available. Therefore the stubs are not even linked. Remove them. Signed-off-by: Philippe Mathieu-Daudé --- target/riscv/kvm-stub.c | 3