Re: [PATCH] tcg/riscv: Fix range matched by TCG_CT_CONST_M12

2022-10-24 Thread Alistair Francis
On Sat, Oct 22, 2022 at 8:19 PM Richard Henderson wrote: > > We were matching a signed 13-bit range, not a 12-bit range. > Expand the commentary within the function and be explicit > about all of the ranges. > > Reported-by: LIU Zhiwei > Signed-off-by: Richard Henderson Thanks! Applied to

Re: [PATCH] tcg/riscv: Fix range matched by TCG_CT_CONST_M12

2022-10-24 Thread Alistair Francis
On Sat, Oct 22, 2022 at 8:19 PM Richard Henderson wrote: > > We were matching a signed 13-bit range, not a 12-bit range. > Expand the commentary within the function and be explicit > about all of the ranges. > > Reported-by: LIU Zhiwei > Signed-off-by: Richard Henderson Reviewed-by: Alistair

Re: [PATCH] tcg/riscv: Fix range matched by TCG_CT_CONST_M12

2022-10-23 Thread LIU Zhiwei
On 2022/10/22 17:58, Richard Henderson wrote: We were matching a signed 13-bit range, not a 12-bit range. Expand the commentary within the function and be explicit about all of the ranges. Reported-by: LIU Zhiwei Signed-off-by: Richard Henderson Reviewed-by: LIU Zhiwei ---

[PATCH] tcg/riscv: Fix range matched by TCG_CT_CONST_M12

2022-10-22 Thread Richard Henderson
We were matching a signed 13-bit range, not a 12-bit range. Expand the commentary within the function and be explicit about all of the ranges. Reported-by: LIU Zhiwei Signed-off-by: Richard Henderson --- tcg/riscv/tcg-target.c.inc | 19 --- 1 file changed, 16 insertions(+), 3