Re: [PATCH] tcg: Mark tcg helpers noinline to avoid an issue with LTO

2023-01-19 Thread Richard Henderson
On 1/19/23 07:11, Peter Maydell wrote: Do we have any chance of persuading the gcc folks to document that 'noinline' also affects function splitting ? That would reduce the chance that they decide to take out the attribute check at some future date... https://gcc.gnu.org/bugzilla/show_bug.cgi?i

Re: [PATCH] tcg: Mark tcg helpers noinline to avoid an issue with LTO

2023-01-19 Thread Idan Horowitz
On 19/01/2023 18:50, Richard Henderson wrote: > Marking helpers __attribute__((noinline)) prevents an issue > with GCC's ipa-split pass under --enable-lto. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1454 > Signed-off-by: Richard Henderson > --- > > Idan, please give this a try.

Re: [PATCH] tcg: Mark tcg helpers noinline to avoid an issue with LTO

2023-01-19 Thread Peter Maydell
On Thu, 19 Jan 2023 at 16:50, Richard Henderson wrote: > > Marking helpers __attribute__((noinline)) prevents an issue > with GCC's ipa-split pass under --enable-lto. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1454 > Signed-off-by: Richard Henderson > --- > > Idan, please give th

Re: [PATCH] tcg: Mark tcg helpers noinline to avoid an issue with LTO

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 17:50, Richard Henderson wrote: Marking helpers __attribute__((noinline)) prevents an issue with GCC's ipa-split pass under --enable-lto. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1454 Signed-off-by: Richard Henderson --- Idan, please give this a try. By inspection, i

[PATCH] tcg: Mark tcg helpers noinline to avoid an issue with LTO

2023-01-19 Thread Richard Henderson
Marking helpers __attribute__((noinline)) prevents an issue with GCC's ipa-split pass under --enable-lto. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1454 Signed-off-by: Richard Henderson --- Idan, please give this a try. By inspection, it fixes the issue with s390x's helper_divs32