Re: [PATCH] tests/avocado: starts PhoneServer upfront

2022-03-11 Thread Beraldo Leal
On Fri, Mar 11, 2022 at 11:18:38AM -0500, Cleber Rosa wrote: > > Beraldo Leal writes: > > > On Fri, Mar 11, 2022 at 09:28:24AM -0500, Cleber Rosa wrote: > >> > >> Beraldo Leal writes: > >> > >> > Race conditions can happen with the current code, because the port that > >> > was available

Re: [PATCH] tests/avocado: starts PhoneServer upfront

2022-03-11 Thread Cleber Rosa
Beraldo Leal writes: > On Fri, Mar 11, 2022 at 09:28:24AM -0500, Cleber Rosa wrote: >> >> Beraldo Leal writes: >> >> > Race conditions can happen with the current code, because the port that >> > was available might not be anymore by the time the server is started. >> > >> > By setting the

Re: [PATCH] tests/avocado: starts PhoneServer upfront

2022-03-11 Thread Beraldo Leal
On Fri, Mar 11, 2022 at 09:28:24AM -0500, Cleber Rosa wrote: > > Beraldo Leal writes: > > > Race conditions can happen with the current code, because the port that > > was available might not be anymore by the time the server is started. > > > > By setting the port to 0, PhoneServer it will use

Re: [PATCH] tests/avocado: starts PhoneServer upfront

2022-03-11 Thread Cleber Rosa
Beraldo Leal writes: > Race conditions can happen with the current code, because the port that > was available might not be anymore by the time the server is started. > > By setting the port to 0, PhoneServer it will use the OS default > behavior to get a free port, then we save this

Re: [PATCH] tests/avocado: starts PhoneServer upfront

2022-03-11 Thread Daniel P . Berrangé
On Fri, Mar 11, 2022 at 10:09:19AM -0300, Beraldo Leal wrote: > Race conditions can happen with the current code, because the port that > was available might not be anymore by the time the server is started. > > By setting the port to 0, PhoneServer it will use the OS default > behavior to get a

[PATCH] tests/avocado: starts PhoneServer upfront

2022-03-11 Thread Beraldo Leal
Race conditions can happen with the current code, because the port that was available might not be anymore by the time the server is started. By setting the port to 0, PhoneServer it will use the OS default behavior to get a free port, then we save this information so we can later configure the