Re: [PATCH] tests/qtest: check the return value

2023-11-21 Thread Thomas Huth
On 21/11/2023 09.08, Zhu Jun wrote: These variables "ret" are never referenced in the code, thus add check logic for the "ret" Signed-off-by: Zhu Jun Thanks! Reviewed-by: Thomas Huth I'll queue it for my next pull request.

[PATCH] tests/qtest: check the return value

2023-11-21 Thread Zhu Jun
These variables "ret" are never referenced in the code, thus add check logic for the "ret" Signed-off-by: Zhu Jun --- tests/qtest/test-filter-mirror.c | 1 + tests/qtest/test-filter-redirector.c | 2 ++ tests/qtest/virtio-net-test.c| 1 + 3 files changed, 4 insertions(+) diff --git

RE: [PATCH] tests/qtest: check the return value

2023-11-20 Thread Zhang, Chen
> -Original Message- > From: zhujun2 > Sent: Tuesday, November 21, 2023 2:17 PM > To: Zhang, Chen > Cc: lviv...@redhat.com; pbonz...@redhat.com; qemu-devel@nongnu.org; > th...@redhat.com; zhuj...@cmss.chinamobile.com > Subject: [PATCH] tests/qtest: c

Re: [PATCH] tests/qtest: check the return value

2023-11-20 Thread Thomas Huth
Thanks, patch looks better this way, but I'd still like to ask you to fix two small issues: On 21/11/2023 07.16, zhujun2 wrote: These variables "ret" are never referenced in the code, that s/, that/, thus/ add check logic for the "ret" Signed-off-by: zhujun2 Could you *please* fix

[PATCH] tests/qtest: check the return value

2023-11-20 Thread zhujun2
These variables "ret" are never referenced in the code, that add check logic for the "ret" Signed-off-by: zhujun2 --- tests/qtest/test-filter-mirror.c | 1 + tests/qtest/test-filter-redirector.c | 2 ++ tests/qtest/virtio-net-test.c| 1 + 3 files changed, 4 insertions(+) diff --git