Re: [PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized

Am 16.01.24 um 13:11 schrieb Fiona Ebner: > Am 15.01.24 um 13:00 schrieb Marc-André Lureau: > The trouble is when qemu_clipboard_update() is called without data & without a request callback set. We shouldn't allow that as we have no means to get the clipboard data then.

Re: [PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized

Am 15.01.24 um 13:00 schrieb Marc-André Lureau: >>> >>> The trouble is when qemu_clipboard_update() is called without data & >>> without a request callback set. We shouldn't allow that as we have no >>> means to get the clipboard data then. >>> >> >> In the above scenario, I'm pretty sure

Re: [PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized

Hi On Mon, Jan 15, 2024 at 3:48 PM Fiona Ebner wrote: > > Am 15.01.24 um 12:33 schrieb Marc-André Lureau: > > Hi > > > > On Mon, Jan 15, 2024 at 3:26 PM Fiona Ebner wrote: > >> > >> Am 15.01.24 um 12:15 schrieb Marc-André Lureau: > >>> Hi > >>> > >>> On Mon, Jan 15, 2024 at 2:45 PM Fiona Ebner

Re: [PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized

Am 15.01.24 um 12:33 schrieb Marc-André Lureau: > Hi > > On Mon, Jan 15, 2024 at 3:26 PM Fiona Ebner wrote: >> >> Am 15.01.24 um 12:15 schrieb Marc-André Lureau: >>> Hi >>> >>> On Mon, Jan 15, 2024 at 2:45 PM Fiona Ebner wrote: Am 14.01.24 um 14:51 schrieb Marc-André Lureau: >>

Re: [PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized

Hi On Mon, Jan 15, 2024 at 3:26 PM Fiona Ebner wrote: > > Am 15.01.24 um 12:15 schrieb Marc-André Lureau: > > Hi > > > > On Mon, Jan 15, 2024 at 2:45 PM Fiona Ebner wrote: > >> > >> Am 14.01.24 um 14:51 schrieb Marc-André Lureau: > > diff --git a/ui/clipboard.c b/ui/clipboard.c >

Re: [PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized

Am 15.01.24 um 12:15 schrieb Marc-André Lureau: > Hi > > On Mon, Jan 15, 2024 at 2:45 PM Fiona Ebner wrote: >> >> Am 14.01.24 um 14:51 schrieb Marc-André Lureau: diff --git a/ui/clipboard.c b/ui/clipboard.c index 3d14bffaf8..c13b54d2e9 100644 --- a/ui/clipboard.c +++

Re: [PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized

Hi On Mon, Jan 15, 2024 at 2:45 PM Fiona Ebner wrote: > > Am 14.01.24 um 14:51 schrieb Marc-André Lureau: > >> > >> diff --git a/ui/clipboard.c b/ui/clipboard.c > >> index 3d14bffaf8..c13b54d2e9 100644 > >> --- a/ui/clipboard.c > >> +++ b/ui/clipboard.c > >> @@ -129,7 +129,8 @@ void

Re: [PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized

Am 14.01.24 um 14:51 schrieb Marc-André Lureau: >> >> diff --git a/ui/clipboard.c b/ui/clipboard.c >> index 3d14bffaf8..c13b54d2e9 100644 >> --- a/ui/clipboard.c >> +++ b/ui/clipboard.c >> @@ -129,7 +129,8 @@ void qemu_clipboard_request(QemuClipboardInfo *info, >> if (info->types[type].data

Re: [PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized

Hi On Fri, Jan 12, 2024 at 5:57 PM Fiona Ebner wrote: > > With VNC, it can be that a client sends a VNC_MSG_CLIENT_CUT_TEXT > message before sending a VNC_MSG_CLIENT_SET_ENCODINGS message with > VNC_ENCODING_CLIPBOARD_EXT for configuring the clipboard extension. > > This means that

Re: [PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized

Am 12.01.24 um 14:55 schrieb Fiona Ebner: > > Then when noVNC sends a VNC_MSG_CLIENT_CUT_TEXT message (it did set > the feature correctly, so the check added by your patch passes), Sorry, forgot to adapt this part. This should read "it did set the VNC_FEATURE_CLIPBOARD_EXT feature correctly, so

[PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized

With VNC, it can be that a client sends a VNC_MSG_CLIENT_CUT_TEXT message before sending a VNC_MSG_CLIENT_SET_ENCODINGS message with VNC_ENCODING_CLIPBOARD_EXT for configuring the clipboard extension. This means that qemu_clipboard_request() can be reached (via vnc_client_cut_text_ext()) before