Re: [PATCH] ui/gtk: Negative Page number is not valid

2024-06-26 Thread Kim, Dongwon
On 6/26/2024 10:06 AM, Philippe Mathieu-Daudé wrote: Hi Dongwon, On 26/6/24 02:08, dongwon@intel.com wrote: From: Dongwon Kim Negative page number means the page with that number does not belong to the notebook so it shouldn't be used as a valid page number in gd_vc_find_by_page. This

Re: [PATCH] ui/gtk: Negative Page number is not valid

2024-06-26 Thread Philippe Mathieu-Daudé
Hi Dongwon, On 26/6/24 02:08, dongwon@intel.com wrote: From: Dongwon Kim Negative page number means the page with that number does not belong to the notebook so it shouldn't be used as a valid page number in gd_vc_find_by_page. This function should just return null in such case. This

[PATCH] ui/gtk: Negative Page number is not valid

2024-06-25 Thread dongwon . kim
From: Dongwon Kim Negative page number means the page with that number does not belong to the notebook so it shouldn't be used as a valid page number in gd_vc_find_by_page. This function should just return null in such case. This change, however, will cause a segfault during detaching