Re: [PATCH] ui: Fix pixel colour channel order for PNG screenshots

2023-05-09 Thread Marc-André Lureau
Hi Peter On Tue, May 9, 2023 at 5:12 PM Peter Maydell wrote: > On Tue, 2 May 2023 at 20:36, Marc-André Lureau > wrote: > > > > > > > > On Tue, May 2, 2023 at 5:56 PM Peter Maydell > wrote: > >> > >> When we take a PNG screenshot the ordering of the colour channels in > >> the data is not

Re: [PATCH] ui: Fix pixel colour channel order for PNG screenshots

2023-05-09 Thread Peter Maydell
On Tue, 2 May 2023 at 20:36, Marc-André Lureau wrote: > > > > On Tue, May 2, 2023 at 5:56 PM Peter Maydell wrote: >> >> When we take a PNG screenshot the ordering of the colour channels in >> the data is not correct, resulting in the image having weird >> colouring compared to the actual

Re: [PATCH] ui: Fix pixel colour channel order for PNG screenshots

2023-05-03 Thread Peter Maydell
On Tue, 2 May 2023 at 21:36, BALATON Zoltan wrote: > > On Tue, 2 May 2023, Peter Maydell wrote: > > When we take a PNG screenshot the ordering of the colour channels in > > the data is not correct, resulting in the image having weird > > colouring compared to the actual display. (Specifically,

Re: [PATCH] ui: Fix pixel colour channel order for PNG screenshots

2023-05-02 Thread BALATON Zoltan
On Tue, 2 May 2023, Peter Maydell wrote: When we take a PNG screenshot the ordering of the colour channels in the data is not correct, resulting in the image having weird colouring compared to the actual display. (Specifically, on a little-endian host the blue and red channels are swapped; on

Re: [PATCH] ui: Fix pixel colour channel order for PNG screenshots

2023-05-02 Thread Marc-André Lureau
On Tue, May 2, 2023 at 5:56 PM Peter Maydell wrote: > When we take a PNG screenshot the ordering of the colour channels in > the data is not correct, resulting in the image having weird > colouring compared to the actual display. (Specifically, on a > little-endian host the blue and red

[PATCH] ui: Fix pixel colour channel order for PNG screenshots

2023-05-02 Thread Peter Maydell
When we take a PNG screenshot the ordering of the colour channels in the data is not correct, resulting in the image having weird colouring compared to the actual display. (Specifically, on a little-endian host the blue and red channels are swapped; on big-endian everything is wrong.) This