Re: [PATCH] util/async.c: Forbid negative min/max in aio_context_set_thread_pool_params()

2024-07-25 Thread Stefan Hajnoczi
On Tue, Jul 23, 2024 at 04:09:27PM +0100, Peter Maydell wrote: > aio_context_set_thread_pool_params() takes two int64_t arguments to > set the minimum and maximum number of threads in the pool. We do > some bounds checking on these, but we don't catch the case where the > inputs are negative. Thi

Re: [PATCH] util/async.c: Forbid negative min/max in aio_context_set_thread_pool_params()

2024-07-23 Thread Philippe Mathieu-Daudé
On 23/7/24 17:51, Peter Maydell wrote: On Tue, 23 Jul 2024 at 16:44, Philippe Mathieu-Daudé wrote: On 23/7/24 17:09, Peter Maydell wrote: aio_context_set_thread_pool_params() takes two int64_t arguments to set the minimum and maximum number of threads in the pool. We do some bounds checking

Re: [PATCH] util/async.c: Forbid negative min/max in aio_context_set_thread_pool_params()

2024-07-23 Thread Peter Maydell
On Tue, 23 Jul 2024 at 16:44, Philippe Mathieu-Daudé wrote: > > On 23/7/24 17:09, Peter Maydell wrote: > > aio_context_set_thread_pool_params() takes two int64_t arguments to > > set the minimum and maximum number of threads in the pool. We do > > some bounds checking on these, but we don't catch

Re: [PATCH] util/async.c: Forbid negative min/max in aio_context_set_thread_pool_params()

2024-07-23 Thread Philippe Mathieu-Daudé
On 23/7/24 17:09, Peter Maydell wrote: aio_context_set_thread_pool_params() takes two int64_t arguments to set the minimum and maximum number of threads in the pool. We do some bounds checking on these, but we don't catch the case where the inputs are negative. This means that later in the func

[PATCH] util/async.c: Forbid negative min/max in aio_context_set_thread_pool_params()

2024-07-23 Thread Peter Maydell
aio_context_set_thread_pool_params() takes two int64_t arguments to set the minimum and maximum number of threads in the pool. We do some bounds checking on these, but we don't catch the case where the inputs are negative. This means that later in the function when we assign these inputs to the A