Re: [PATCH] vdpa: Fix file descriptor leak on get features error

2022-08-01 Thread Michael S. Tsirkin
On Mon, Aug 01, 2022 at 08:48:41PM +0200, Eugenio Perez Martin wrote: > On Mon, Aug 1, 2022 at 8:34 PM Peter Maydell wrote: > > > > On Mon, 1 Aug 2022 at 19:31, Laurent Vivier wrote: > > > > > > On 01/08/2022 16:47, Eugenio Pérez wrote: > > > > File descriptor vdpa_device_fd is not free in the ca

Re: [PATCH] vdpa: Fix file descriptor leak on get features error

2022-08-01 Thread Eugenio Perez Martin
On Mon, Aug 1, 2022 at 8:34 PM Peter Maydell wrote: > > On Mon, 1 Aug 2022 at 19:31, Laurent Vivier wrote: > > > > On 01/08/2022 16:47, Eugenio Pérez wrote: > > > File descriptor vdpa_device_fd is not free in the case of returning > > > error from vhost_vdpa_get_features. Fixing it by making all

Re: [PATCH] vdpa: Fix file descriptor leak on get features error

2022-08-01 Thread Peter Maydell
On Mon, 1 Aug 2022 at 19:31, Laurent Vivier wrote: > > On 01/08/2022 16:47, Eugenio Pérez wrote: > > File descriptor vdpa_device_fd is not free in the case of returning > > error from vhost_vdpa_get_features. Fixing it by making all errors go to > > the same error path. > > > > Resolves: Coverity

Re: [PATCH] vdpa: Fix file descriptor leak on get features error

2022-08-01 Thread Laurent Vivier
On 01/08/2022 16:47, Eugenio Pérez wrote: File descriptor vdpa_device_fd is not free in the case of returning error from vhost_vdpa_get_features. Fixing it by making all errors go to the same error path. Resolves: Coverity CID 1490785 Fixes: 8170ab3f43 ("vdpa: Extract get features part from vho

[PATCH] vdpa: Fix file descriptor leak on get features error

2022-08-01 Thread Eugenio Pérez
File descriptor vdpa_device_fd is not free in the case of returning error from vhost_vdpa_get_features. Fixing it by making all errors go to the same error path. Resolves: Coverity CID 1490785 Fixes: 8170ab3f43 ("vdpa: Extract get features part from vhost_vdpa_get_max_queue_pairs") Signed-off-by