Re: [PATCH] vdpa: fix emulated guest announce feature status handling

2023-03-15 Thread Gautam Dawar
On 3/3/23 20:28, Eugenio Perez Martin wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On Fri, Mar 3, 2023 at 12:58 PM Gautam Dawar wrote: Guest announce capability is emulated by qemu in the

Re: [PATCH] vdpa: fix emulated guest announce feature status handling

2023-03-03 Thread Eugenio Perez Martin
On Fri, Mar 3, 2023 at 12:58 PM Gautam Dawar wrote: > > Guest announce capability is emulated by qemu in the .avail_handler > shadow virtqueue operation. It updates the status to success in > `*s->status` but incorrectly fetches the command execution > status from local variable `status` later in

[PATCH] vdpa: fix emulated guest announce feature status handling

2023-03-03 Thread Gautam Dawar
Guest announce capability is emulated by qemu in the .avail_handler shadow virtqueue operation. It updates the status to success in `*s->status` but incorrectly fetches the command execution status from local variable `status` later in call to iov_from_buf(). As `status` is initialized to

Re: [PATCH] vdpa: fix emulated guest announce feature status handling

2023-03-03 Thread Michael S. Tsirkin
On Fri, Mar 03, 2023 at 05:28:10PM +0530, Gautam Dawar wrote: > Guest announce capability is emulated by qemu in the .avail_handler > shadow virtqueue operation. It updates the status to success in > `*s->status` but incorrectly fetches the command execution > status from local variable `status`