Re: [PATCH] vdpa net: zero vhost_vdpa iova_tree pointer at cleanup

2023-09-15 Thread Si-Wei Liu
On 9/13/2023 5:34 AM, Eugenio Pérez wrote: Not zeroing it causes a SIGSEGV if the live migration is cancelled, at net device restart. This is caused because CVQ tries to reuse the iova_tree that is present in the first vhost_vdpa device at the end of vhost_vdpa_net_cvq_start. As a

Re: [PATCH] vdpa net: zero vhost_vdpa iova_tree pointer at cleanup

2023-09-14 Thread Lei Yang
QE tested this patch with real nic,guest can works well after cancelling migration. Tested-by: Lei Yang On Thu, Sep 14, 2023 at 11:23 AM Jason Wang wrote: > > On Wed, Sep 13, 2023 at 8:34 PM Eugenio Pérez wrote: > > > > Not zeroing it causes a SIGSEGV if the live migration is cancelled, at >

Re: [PATCH] vdpa net: zero vhost_vdpa iova_tree pointer at cleanup

2023-09-13 Thread Jason Wang
On Wed, Sep 13, 2023 at 8:34 PM Eugenio Pérez wrote: > > Not zeroing it causes a SIGSEGV if the live migration is cancelled, at > net device restart. > > This is caused because CVQ tries to reuse the iova_tree that is present > in the first vhost_vdpa device at the end of

[PATCH] vdpa net: zero vhost_vdpa iova_tree pointer at cleanup

2023-09-13 Thread Eugenio Pérez
Not zeroing it causes a SIGSEGV if the live migration is cancelled, at net device restart. This is caused because CVQ tries to reuse the iova_tree that is present in the first vhost_vdpa device at the end of vhost_vdpa_net_cvq_start. As a consequence, it tries to access an iova_tree that has been